Deployment: Updating API comments #15273
Merged
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
size/S
|
Labelling this PR as size/S |
|
GCE e2e build/test failed for commit d5dd4b9b7d788415a7f9062d2bcd9403ca1b76d9. |
| @@ -279,11 +279,11 @@ type RollingUpdateDeployment struct { | |||
| } | |||
|
|
|||
| type DeploymentStatus struct { | |||
| // Total number of ready pods targeted by this deployment (this | |||
| // Total number of pods targeted by this deployment (this | |||
There was a problem hiding this comment.
Technically, it doesn't include terminated pods.
There was a problem hiding this comment.
Updated the comment to say "number of non-terminated pods"
nikhiljindal
force-pushed
the
deploymentAPI
branch
from
d5dd4b9 to
b3e659a
Compare
|
@bgrant0607 Updated the code as per comment. PTAL |
nikhiljindal
force-pushed
the
deploymentAPI
branch
from
b3e659a to
3e543d7
Compare
|
LGTM |
bgrant0607
added
lgtm
|
GCE e2e test build/test passed for commit b3e659a260436a2e41e8179895e80f5c4701f6cb. |
nikhiljindal
force-pushed
the
deploymentAPI
branch
from
3e543d7 to
119150f
Compare
|
GCE e2e test build/test passed for commit 3e543d7ec2c0c8ea9e1bc1f393c1e90f23cc9717. |
|
Ran |
nikhiljindal
added
lgtm
|
GCE e2e test build/test passed for commit 119150f. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 8, 2015
Auto commit by PR queue bot
k8s-github-robot
referenced
this pull request
Oct 13, 2015
…#15273-upstream-release-1.1 Auto commit by PR queue bot
shyamjvs
referenced
this pull request
in shyamjvs/kubernetes
Dec 1, 2016
…y-pick-of-#15273-upstream-release-1.1 Auto commit by PR queue bot
shouhong
referenced
this pull request
in shouhong/kubernetes
Feb 14, 2017
…y-pick-of-#15273-upstream-release-1.1 Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating some API comments:
cc @bgrant0607 @ironcladlou @ghodss