Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to deployment e2e #14917

Merged
merged 1 commit into from
Oct 2, 2015
Merged

Improvements to deployment e2e #14917

merged 1 commit into from
Oct 2, 2015
+229 −64

Conversation

nikhiljindal
Copy link
Contributor

Ref #1743

Adding more test cases to deployment e2e:

  • Added a case to ensure that we do not break the contract for maxUnavailable and maxSurge during the update.
  • Added a case to ensure that RCs are scaled up and down in the expected order. Added events for scaling changes and using them in tests.

Also, found and fixed a bug in the controller.
Also, fixed DeploymentControllerSyncPeriod to be same as other controllers.

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 1, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-bot
Copy link

k8s-bot commented Oct 1, 2015

Unit, integration and GCE e2e build/test failed for commit 68e684b49530d5f45f8c264471d113b8b2f56ca1.

@k8s-bot
Copy link

k8s-bot commented Oct 1, 2015

Unit, integration and GCE e2e build/test failed for commit f917be3d89fea6a3fb34b9ab5218e1f191ca5139.

@k8s-bot
Copy link

k8s-bot commented Oct 1, 2015

Unit, integration and GCE e2e build/test failed for commit c6deb44.

@nikhiljindal nikhiljindal changed the title WIP: Improvements to deployment e2e Improvements to deployment e2e Oct 1, 2015
@nikhiljindal nikhiljindal assigned ironcladlou and unassigned eparis Oct 1, 2015
@nikhiljindal
Copy link
Contributor Author

cc @ghodss @ironcladlou

@nikhiljindal
Copy link
Contributor Author

@k8s-bot ok to test

@ironcladlou
Copy link
Contributor

No time to review in depth tonight, but wanted to mention there's overlap here with #14130 (especially the refactorings to use the utility which I've incorporated into my rebased branch). Would you consider working to get #14130 in shape and merged before further refactoring in an effort to minimize conflicts as we continue to iterate?

@k8s-bot
Copy link

k8s-bot commented Oct 2, 2015

Unit, integration and GCE e2e test build/test passed for commit c6deb44.

@nikhiljindal
Copy link
Contributor Author

I am trying to get this in 1.1

@ironcladlou
Copy link
Contributor

LGTM. I will rebase after this lands.

@ironcladlou ironcladlou mentioned this pull request Oct 2, 2015
Closed
@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Oct 2, 2015

Unit, integration and GCE e2e test build/test passed for commit c6deb44.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Oct 2, 2015
Merge pull request #14917 from nikhiljindal/deploymentController
7007481 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 7007481 into kubernetes:master Oct 2, 2015
@nikhiljindal nikhiljindal mentioned this pull request Oct 8, 2015
Merged
nikhiljindal added a commit that referenced this pull request Oct 9, 2015
@nikhiljindal
Merge pull request #15321 from nikhiljindal/automated-cherry-pick-of-…
f57a8d1 
…#14917-upstream-release-1.1

Automated cherry pick of #14917 upstream release 1.1
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@nikhiljindal
Merge pull request kubernetes#15321 from nikhiljindal/automated-cherr…
b6071a5 
…y-pick-of-#14917-upstream-release-1.1

Automated cherry pick of kubernetes#14917 upstream release 1.1
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
@nikhiljindal
Merge pull request kubernetes#15321 from nikhiljindal/automated-cherr…
130cde8 
…y-pick-of-#14917-upstream-release-1.1

Automated cherry pick of kubernetes#14917 upstream release 1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ironcladlou ironcladlou

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhiljindal @k8s-github-robot @k8s-bot @ironcladlou @googlebot @eparis