Adding an e2e test for deployment #14594
Merged
+177
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ixdy to look at jenkins changes |
|
Unit, integration and GCE e2e build/test failed for commit 41b41937e1dc8a50fb96d32798ec0ba6c8f7ac1c. |
nikhiljindal
force-pushed
the
deploymentE2e
branch
from
41b4193 to
d61ed52
Compare
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
|
Unit, integration and GCE e2e test build/test passed for commit d61ed52. |
|
LGTM |
|
Adding LGTM tag as per comment above |
nikhiljindal
added
the
lgtm
|
@k8s-oncall this is for v1.1 - Can I have a merge, plz? |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Unit, integration and GCE e2e test build/test passed for commit d61ed52. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Sep 29, 2015
Auto commit by PR queue bot
k8s-github-robot
referenced
this pull request
Oct 1, 2015
…#14594-upstream-release-1.1 Auto commit by PR queue bot
This was referenced Oct 3, 2015
shyamjvs
referenced
this pull request
in shyamjvs/kubernetes
Dec 1, 2016
…y-pick-of-#14594-upstream-release-1.1 Auto commit by PR queue bot
shouhong
referenced
this pull request
in shouhong/kubernetes
Feb 14, 2017
…y-pick-of-#14594-upstream-release-1.1 Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1743
This a basic test that just tests the end state (old pods should have vanished and new pods should be scaled to the desired replicas).
We are not testing that we dont break maxSurge and maxAvailability during the update.
Will add tests for that when we have updated deployment controller to raise events each time it scales up or down (being done by #14130)
cc @ghodss @ironcladlou