Allow enabling deployment controller on GCE and GKE #14463
Merged
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning to @jszczepkowski since the changes are same as in #13547 |
|
GCE e2e build/test passed for commit 8914a634569e0e1552551139ccfaaea5cb2dfb31. |
k8s-github-robot
added
the
size/M
|
Labelling this PR as size/M |
|
LGTM |
jszczepkowski
added
the
lgtm
nikhiljindal
force-pushed
the
DeploymentOnGCE
branch
from
8914a63 to
eece1c1
Compare
nikhiljindal
force-pushed
the
DeploymentOnGCE
branch
from
eece1c1 to
ed5d24e
Compare
k8s-github-robot
added
size/S
|
Labelling this PR as size/S |
|
GCE e2e build/test passed for commit eece1c1a4d432c2cb02a7fdb1c9ea555b922e581. |
|
GCE e2e build/test passed for commit ed5d24e. |
|
Fixed travis failure. Readding LGTM tag |
nikhiljindal
added
lgtm
mwielgus
added a commit
that referenced
this pull request
Sep 25, 2015
Allow enabling deployment controller on GCE and GKE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1743
Adding KUBE_ENABLE_DEPLOYMENTS env flag, which enables deployments in the cluster.
The changes are exactly the same as in #13547
Verified that
KUBE_ENABLE_DEPLOYMENTS=true ./cluster/kube-up.shworks as expected.cc @ghodss @ironcladlou