Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design doc for DaemonSet #14326

Closed
wants to merge 0 commits into from
Closed

Design doc for DaemonSet #14326

wants to merge 0 commits into from

Conversation

davidopp
Copy link
Member

This is just #13368 with all of the reviewer comments addressed.

@mikedanese @bgrant0607

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@k8s-bot
Copy link

k8s-bot commented Sep 22, 2015

GCE e2e build/test passed for commit 85e0814.

@timothysc
Copy link
Member

/cc @smarterclayton @eparis

- In general, for all the supported features like get, describe, update, etc, the DaemonSet works in a similar way to the Replication Controller. However, note that the DaemonSet and the Replication Controller are different constructs.

### Persisting Pods
- Ordinary livenes probes specified in the pod template work to keep pods created by a DaemonSet running.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 22, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

- The spec for DaemonSets has a pod template field.
- Using the pod’s nodeSelector field, DaemonSets can be restricted to operate over nodes that have a certain label. For example, suppose that in a cluster some nodes are labeled ‘app=database’. You can use a DaemonSet to launch a datastore pod on exactly those nodes labeled ‘app=database’.
- Using the pod's node name field, DaemonSets can be restricted to operate on a specified nodeName.
- The PodTemplateSpec used by the DaemonSet is the same as the PodTemplateSpec usedby the Replication Controller.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used by

@bgrant0607
Copy link
Member

Re. evolution of this API:

Before DaemonSet graduates from experimental, it needs to adopt the more general selector, as discussed in #341. This would be very hard to change later.

Before DaemonSet reaches v1beta1, I'd like to see:

Before DaemonSet reaches v1, I'd like to see:

@mikedanese
Copy link
Member

ref #1518

@davidopp
Copy link
Member Author

I did something bad in Github, so I had to send out a new PR (#14529). It incorporates the fixes described above. Sorry for the inconvenience (and thanks to @mikedanese for helping me get git back into a sane state).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants