Adding an example deployment yaml #14319
Conversation
|
GCE e2e build/test passed for commit ca430313e6e735e249969cc716ed66bb26243536. |
k8s-github-robot
added
the
size/M
|
Labelling this PR as size/M |
|
On Mon, Sep 21, 2015 at 8:10 PM, k8s-merge-robot notifications@github.com
|
|
LGTM |
| @@ -369,7 +379,11 @@ func TestExampleObjectSchemas(t *testing.T) { | |||
| } | |||
| //TODO: Add validate method for &schedulerapi.Policy | |||
| } else { | |||
| if err := testapi.Default.Codec().DecodeInto(data, expectedType); err != nil { | |||
| codec := testapi.Default.Codec() | |||
| if strings.HasSuffix(path, "examples/experimental") { | |||
There was a problem hiding this comment.
This looks questionable to me. Is it possible an experimental example needs to use a v1 object? I think it's more robust to deduce the group by using the expectedType.
My pending PR has added such a function to testapi, https://github.com/kubernetes/kubernetes/pull/14156/files#diff-59998217138141c72ed55d8a701cd00fR214
Do you want to try that?
nikhiljindal
force-pushed
the
deploymentExamplew
branch
from
ca43031 to
4841d08
Compare
|
@caesarxuchao Updated code as per your comment. I copied GetCodecForObject from your PR. PTAL |
|
GCE e2e build/test passed for commit 4841d08908d8d46ddd9cfe21dd4c44ce3b2333db. |
|
Thank you. LGTM. I guess if I don't change the function in my PR, then neither of us would need to do a rebase? |
caesarxuchao
added
lgtm
nikhiljindal
force-pushed
the
deploymentExamplew
branch
from
4841d08 to
60bd401
Compare
|
Actually there was a slight difference in order of imports. Fixed it now, so that none of us will have to rebase. |
|
GCE e2e build/test passed for commit 60bd401. |
|
Thank you @nikhiljindal. LGTM. |
Adding an example deployment yaml
Ref #1743
Assigning to @caesarxuchao to review the examples_test changes.
cc @ghodss