Adding a DeploymentDescriber to kubectl #14199

nikhiljindal · 2015-09-18T20:39:55Z

Adding a DeploymentDescriber to describe deployment objects using kubectl describe deployments
Sample output:

Name:                           nginx-deployment
Namespace:                      default
CreationTimestamp:              Sun, 27 Sep 2015 20:04:35 -0700
Labels:                         name=nginx-deployment
Selector:                       name=nginx
Replicas:                       3 updated / 3 total
StrategyType:                   RollingUpdate
RollingUpdateStrategy:          1 max unavailable, 1 max surge, 0 min ready seconds
OldReplicationControllers:      <none>
NewReplicationController:      deploymentrc-729166632 (3/3 replicas created)

nikhiljindal · 2015-09-18T20:41:00Z

cc @ghodss @ironcladlou

k8s-github-robot · 2015-09-18T21:15:50Z

Labelling this PR as size/M

k8s-bot · 2015-09-18T21:16:15Z

GCE e2e build/test passed for commit 382c2b51d15e961bf5aba2c2ba2624f902f78405.

ghodss · 2015-09-19T10:29:26Z

pkg/kubectl/describe.go

+		fmt.Fprintf(out, "StrategyType:\t%s\n", d.Spec.Strategy.Type)
+		if d.Spec.Strategy.RollingUpdate != nil {
+			ru := d.Spec.Strategy.RollingUpdate
+			fmt.Fprintf(out, "RollingUpdateStrategy:\t%s maxUnavailable, %s maxSurge, %d minReadySeconds", ru.MaxUnavailable.String(), ru.MaxSurge.String(), ru.MinReadySeconds)


I like describe to a bit more human-friendly, so I would suggest "max unavailable", "max surge", etc.

ghodss · 2015-09-19T10:30:30Z

In the console output, the values all line up, right?

ghodss · 2015-09-19T10:31:52Z

LGTM, but maybe someone else from @kubernetes/kubectl wants to take a look.

smarterclayton · 2015-09-19T16:55:44Z

pkg/kubectl/describe.go

+}
+
+func (dd *DeploymentDescriber) Describe(namespace, name string) (string, error) {
+	d, err := dd.Experimental().Deployments(namespace).Get(name)


We should get the replication controllers managed by this dep and show them in some order. If they can be loaded we shouldn't hard fail (show error and continue)

If we really want them, then instead of recomputing them here, I would prefer that deployment controller adds them to the DeploymentStatus and we just display it here.
I think we had discussed doing that in the proposal, but then decided against it.

I would agree with @smarterclayton here. Keeping copies of other objects' state in the Deployment object's status will either be frequently out of date or will lead to lots of extraneous updates to apiserver. At the very most, perhaps the matching RC names should be in the status (and, during a deployment, both the old RC's and the new RC's).

Right. Thats the reason why we decided not to store anything.

The comparison I'm drawing is to the pod describer where we fetch the replication controllers that overlap the pod. I think users would expect the same here - I'm ok with showing status, but it is common to want to know whether you have multiple RCs in flight during a deployment. Getting the list of RCs and even showing what the D controller thinks is the status is both good. The note about not failing was just that if the RC is borked for some reason we don't want to prevent describe from working.

nikhiljindal · 2015-09-21T02:54:08Z

Yes, values line up in the console output.

k8s-bot · 2015-09-21T03:10:09Z

GCE e2e build/test passed for commit f4dcd38dabdd2ba1bf9d9e6a7a40bac928655098.

k8s-bot · 2015-09-25T22:41:07Z

Unit, integration and GCE e2e build/test failed for commit 62a8d4217d9b2549b8bdbe60404762ad83b354f7.

k8s-bot · 2015-09-28T02:39:26Z

Unit, integration and GCE e2e build/test failed for commit da0577870b65f23d36787cdca85cf10e22c363fd.

k8s-github-robot · 2015-09-28T02:51:20Z

Labelling this PR as size/L

nikhiljindal · 2015-09-28T03:18:46Z

Have updated the code to include old and new RC in output. PTAL.

k8s-bot · 2015-09-28T03:21:41Z

Unit, integration and GCE e2e build/test failed for commit 9353594c16c887f4b5c4a845456ea785ddb16224.

k8s-bot · 2015-09-28T03:24:22Z

Unit, integration and GCE e2e build/test failed for commit 39c256ccdcb9908adaa30e7aefedd3154f9e3c6e.

nikhiljindal · 2015-09-29T17:59:45Z

Closing and reopening to retrigger Jenkins. It has been pending for 20 hours.

nikhiljindal · 2015-09-29T18:00:27Z

Adding LGTM label as per @ironcladlou's LGTM above.

nikhiljindal · 2015-09-29T19:12:32Z

@k8s-bot test this please

k8s-bot · 2015-09-29T20:18:10Z

Unit, integration and GCE e2e build/test failed for commit 153c57f.

nikhiljindal · 2015-09-29T20:54:53Z

oidc.TestOIDCAuthentication (from k8s.io_kubernetes_plugin_pkg_auth_authenticator_token_oidc) failed, which seems flaky. Retrying.

@k8s-bot ok to test

k8s-bot · 2015-09-29T21:31:41Z

Unit, integration and GCE e2e test build/test passed for commit 153c57f.

nikhiljindal · 2015-09-30T21:24:41Z

@k8s-bot ok to test

k8s-bot · 2015-09-30T22:19:19Z

Unit, integration and GCE e2e build/test failed for commit 153c57f.

nikhiljindal · 2015-09-30T22:28:33Z

Logs show all tests passed.
@k8s-bot ok to test

k8s-bot · 2015-09-30T23:24:30Z

Unit, integration and GCE e2e build/test failed for commit 153c57f.

nikhiljindal · 2015-09-30T23:26:52Z

TestPluginTearDownHook failed which is unrelated. seems flaky.
@k8s-bot ok to test

k8s-bot · 2015-10-01T00:25:40Z

Unit, integration and GCE e2e build/test failed for commit 153c57f.

nikhiljindal · 2015-10-01T00:28:05Z

TestPluginSetupHook this time.
@k8s-bot ok to test

k8s-bot · 2015-10-01T01:50:20Z

Unit, integration and GCE e2e build/test failed for commit 153c57f.

nikhiljindal · 2015-10-01T02:11:31Z

exec.TestPluginTearDownHook again
@k8s-bot ok to test

k8s-bot · 2015-10-01T02:39:58Z

Unit, integration and GCE e2e build/test failed for commit 153c57f.

nikhiljindal · 2015-10-01T03:31:46Z

cni_test.go:175: Failed to select the desired plugin: Network plugin "cni" not found.

@k8s-bot ok to test

k8s-bot · 2015-10-01T04:09:22Z

Unit, integration and GCE e2e build/test failed for commit 153c57f.

k8s-bot · 2015-10-01T04:12:59Z

Unit, integration and GCE e2e test build/test passed for commit 153c57f.

Adding a DeploymentDescriber to kubectl

…#14199-upstream-release-1.1 Automated cherry pick of #14199 upstream release 1.1

…y-pick-of-#14199-upstream-release-1.1 Automated cherry pick of kubernetes#14199 upstream release 1.1

googlebot added the cla: yes label Sep 18, 2015

nikhiljindal assigned ghodss Sep 18, 2015

k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2015

ghodss reviewed Sep 19, 2015
View reviewed changes

smarterclayton reviewed Sep 19, 2015
View reviewed changes

nikhiljindal force-pushed the deploymentDescribe branch from 382c2b5 to f4dcd38 Compare September 21, 2015 02:47

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2015

nikhiljindal added this to the v1.1 milestone Sep 24, 2015

nikhiljindal force-pushed the deploymentDescribe branch from f4dcd38 to 62a8d42 Compare September 25, 2015 22:33

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2015

nikhiljindal force-pushed the deploymentDescribe branch 2 times, most recently from b0ea1c5 to da05778 Compare September 28, 2015 02:10

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2015

nikhiljindal force-pushed the deploymentDescribe branch 3 times, most recently from 39c256c to 38e5dca Compare September 28, 2015 03:18

nikhiljindal closed this Sep 29, 2015

nikhiljindal reopened this Sep 29, 2015

nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2015

nikhiljindal closed this Sep 30, 2015

nikhiljindal reopened this Sep 30, 2015

nikhiljindal added a commit that referenced this pull request Oct 1, 2015

Merge pull request #14199 from nikhiljindal/deploymentDescribe

7adb463

Adding a DeploymentDescriber to kubectl

nikhiljindal merged commit 7adb463 into kubernetes:master Oct 1, 2015

nikhiljindal mentioned this pull request Oct 7, 2015

Automated cherry pick of #14199 upstream release 1.1 #15259

Merged

nikhiljindal added a commit that referenced this pull request Oct 8, 2015

Merge pull request #15259 from nikhiljindal/automated-cherry-pick-of-…

4389700

…#14199-upstream-release-1.1 Automated cherry pick of #14199 upstream release 1.1

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

Merge pull request kubernetes#15259 from nikhiljindal/automated-cherr…

cb9ef6e

…y-pick-of-#14199-upstream-release-1.1 Automated cherry pick of kubernetes#14199 upstream release 1.1

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

Merge pull request kubernetes#15259 from nikhiljindal/automated-cherr…

b68ff7c

…y-pick-of-#14199-upstream-release-1.1 Automated cherry pick of kubernetes#14199 upstream release 1.1

Adding a DeploymentDescriber to kubectl #14199

Adding a DeploymentDescriber to kubectl #14199

Conversation

nikhiljindal commented Sep 18, 2015

nikhiljindal commented Sep 18, 2015

k8s-github-robot commented Sep 18, 2015

k8s-bot commented Sep 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghodss commented Sep 19, 2015

ghodss commented Sep 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhiljindal commented Sep 21, 2015

k8s-bot commented Sep 21, 2015

k8s-bot commented Sep 25, 2015

k8s-bot commented Sep 28, 2015

k8s-github-robot commented Sep 28, 2015

nikhiljindal commented Sep 28, 2015

k8s-bot commented Sep 28, 2015

k8s-bot commented Sep 28, 2015

nikhiljindal commented Sep 29, 2015

nikhiljindal commented Sep 29, 2015

nikhiljindal commented Sep 29, 2015

k8s-bot commented Sep 29, 2015

nikhiljindal commented Sep 29, 2015

k8s-bot commented Sep 29, 2015

nikhiljindal commented Sep 30, 2015

k8s-bot commented Sep 30, 2015

nikhiljindal commented Sep 30, 2015

k8s-bot commented Sep 30, 2015

nikhiljindal commented Sep 30, 2015

k8s-bot commented Oct 1, 2015

nikhiljindal commented Oct 1, 2015

k8s-bot commented Oct 1, 2015

nikhiljindal commented Oct 1, 2015

k8s-bot commented Oct 1, 2015

nikhiljindal commented Oct 1, 2015

k8s-bot commented Oct 1, 2015

k8s-bot commented Oct 1, 2015