Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job and DaemonSet documentation. #14079

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Job and DaemonSet documentation. #14079

merged 1 commit into from
Sep 25, 2015
+562 −11

Conversation

erictune
Copy link
Member

Not ready for final review, but putting this out there so people know I am working on it.

@mikedanese mikedanese self-assigned this Sep 16, 2015
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 16, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-bot
Copy link

k8s-bot commented Sep 16, 2015

GCE e2e build/test failed for commit 70cab5d36834ce3a6cdd7bc1b5c51d8c30a1e5b0.

@erictune
Copy link
Member Author

Ugh. Somehow update-generated-docs.sh presubmit deleted all my documentation text.

@k8s-github-robot
Copy link

Labelling this PR as size/L

@lavalamp
Copy link
Member

@erictune if you ever committed it, you should be able to get it back, even if you rebased it away.

@davidopp
Copy link
Member

@erictune Is this meant to replace #14079 or do you see them as complementary?

@davidopp
Copy link
Member

Sorry I meant #13368

@davidopp davidopp mentioned this pull request Sep 17, 2015
Closed
@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 606374d5b7a4787a8aa458b0f8e7178b0c1d9b8f.

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XL

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2015
@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 669a19315eb02a4e42c0a63dae19c517f45e12df.

@erictune erictune changed the title WIP: Job and DaemonSet documentation. Job and DaemonSet documentation. Sep 21, 2015
@pmorie
Copy link
Member

pmorie commented Sep 21, 2015

@kubernetes/rh-cluster-infra

@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 2852df8762158b01d9e6a8ed47cbe2619ea3c1e6.

@erictune
Copy link
Member Author

@mikedanese @soltysh @AnanyaKumar this is ready for you to take a look at it

@k8s-bot
Copy link

k8s-bot commented Sep 22, 2015

GCE e2e build/test passed for commit 48bcd0cac6f4f290e1c6996b068bbfad6dd0dd2c.

@davidopp
Copy link
Member

Note that we're also going to be submitting Ananya's original design doc (#14326) but your doc makes sense as the user-consumable documentation.

@k8s-bot
Copy link

k8s-bot commented Sep 22, 2015

GCE e2e build/test passed for commit 4db983ae62fb995081ebff12f0bd453f01c38107.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2015
@erictune
Copy link
Member Author

@davidopp Sorry for slow response. Yes, this was meant to user-focused and task-oriented -- a complement to the design doc.

@soltysh
Copy link
Contributor

soltysh commented Sep 24, 2015

Now you have my 100% LGTM 😄

@erictune
Copy link
Member Author

@k8s-oncall this is only docs and test code and comments. You may merge despite free if you like.

derekwaynecarr
derekwaynecarr reviewed Sep 24, 2015
View reviewed changes
docs/admin/daemons.md
## How Daemon Pods are Scheduled

Normally, the machine that a pod runs on is selected by the Kubernetes scheduler. However, pods
create by the Daemon controller have the machine already selected (`.spec.nodeName` is specified
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pods created by

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mikedanese mikedanese added kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 24, 2015
derekwaynecarr
derekwaynecarr reviewed Sep 24, 2015
View reviewed changes
docs/admin/daemons.md
are called [static pods](static-pods.md).
Unlike DaemonSet, static pods cannot be managed with kubectl
or other Kubernetes API clients. Static pods do not depend on the apiserver, making them useful
in cluster bootstrapping cases. Also, static pods may be deprecated in the future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to verify this, but if your cluster rejects the ability to run privileged containers in the api-server, you could have a configuration where the kubelet enables the ability to run privileged containers. As a result, you could have a configuration where the use of static pods could be enabled to support running a privileged container, but the daemonset would be rejected from running a privileged container.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think you could have that situation.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2015
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2015
@k8s-bot
Copy link

k8s-bot commented Sep 24, 2015

GCE e2e build/test passed for commit 86ee4b6a8ba4a943856c0aeb1861bf21a9825ae1.

@bgrant0607
Copy link
Member

Needs rebase

@bgrant0607 bgrant0607 added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2015
@erictune erictune removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2015
bgrant0607
bgrant0607 reviewed Sep 25, 2015
View reviewed changes
docs/admin/daemon.yaml
metadata:
name: prometheus-node-exporter
labels:
name: prometheus-node-exporter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use "name" as a label key.
https://github.com/kubernetes/kubernetes/blob/master/docs/user-guide/config-best-practices.md

How about something like daemon: monitoring? If I were a cluster admin, I'd probably use the same label key for all my node agents / daemons, but not name. name is too generic (it could overlap with non-daemon pods) and confusing for users (due to similarity with metadata.name).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@k8s-bot
Copy link

k8s-bot commented Sep 25, 2015

GCE e2e build/test passed for commit 1c168e422bbe71f51df2746ff0c43891bfdcb7f0.

@erictune
Copy link
Member Author

Fixed to use apiVersion: experimental/v1alpha1

@k8s-bot
Copy link

k8s-bot commented Sep 25, 2015

GCE e2e build/test passed for commit bf9e932.

bgrant0607 added a commit that referenced this pull request Sep 25, 2015
@bgrant0607
Merge pull request #14079 from erictune/job_docs
ba89c98 
Job and DaemonSet documentation.
@bgrant0607 bgrant0607 merged commit ba89c98 into kubernetes:master Sep 25, 2015
@erictune erictune deleted the job_docs branch September 29, 2015 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.