Horizontal Pod Autoscaler is deleted along with namespace #13786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 9d60963a6bbd8fcf459289f4ddacb3ba7448457a. |
|
Assigned @mwielgus who is a big fan a this attitude. |
| @@ -103,6 +103,7 @@ func (rc *ResourceConsumer) sendConsumeCPUrequests(requests, millicores, duratio | |||
|
|
|||
| // sendOneConsumeCPUrequest sends POST request for cpu consumption | |||
| func (rc *ResourceConsumer) sendOneConsumeCPUrequest(millicores int, durationSec int) { | |||
| defer GinkgoRecover() | |||
There was a problem hiding this comment.
when err (from sending post request) is not nil, then we need defer GinkgoRecover().
sendOneConsumeCPUrequest is always in a new gorutine.
|
GCE e2e build/test passed for commit d5c5dc6e51e525601ef537f306ba07f7e0edc116. |
k8s-github-robot
added
the
size/XS
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
needs-rebase
|
@socaa could you please rebase this PR? |
|
@piosz done |
piosz
added
lgtm
|
LGTM |
|
GCE e2e build/test failed for commit d6d199d. |
|
@k8s-bot test this please |
|
GCE e2e build/test passed for commit d6d199d. |
mwielgus
added a commit
that referenced
this pull request
Sep 18, 2015
Horizontal Pod Autoscaler is deleted along with namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11570
@piosz
@mwielgus