-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Reintroduce graceful deletion with e2e passing #12931
Conversation
GCE e2e build/test failed for commit 5ba01b514f1493386151f0a9291bc18b54e55dad. |
cc @yujuhong |
I have some more e2e tests, this is still WIP until I've nailed them all. On Wed, Aug 19, 2015 at 1:27 PM, Brian Grant notifications@github.com
Clayton Coleman | Lead Engineer, OpenShift |
5ba01b5
to
5d0a804
Compare
GCE e2e build/test failed for commit 5d0a804e805f222c5c1615eaa436378e9475db00. |
5d0a804
to
e0de689
Compare
GCE e2e build/test failed for commit e0de689dd866421f083992d902a5900f65aca445. |
cc @gmarek re. node controller |
First two commits are in other pulls #12926 |
e0de689
to
3061595
Compare
This means if List() fails nodes are considered deleted (which is bad)
…n/graceful"" This reverts commit 08e6a43.
Prevents a failure of the node controller from deleting the node without completing the eviction of the node. As long as there are pods on the node, the node won't be deleted.
GCE e2e build/test failed for commit 3061595. |
One failure:
|
It's a flake, I opened a defect. I'm still running e2e tests locally, I On Aug 19, 2015, at 7:41 PM, Yu-Ju Hong notifications@github.com wrote: One failure: • Failure [31.586 seconds]
&{/jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/kubernetes/platforms/linux/amd64/kubectl
— |
I'm closing this in favor of incremental commits so we can land the non-user impacting code distinct from the actual enabling code and pain caused by rebasing reverts. See links from #9165. Reviews appreciated. |
Revert the revert of #9165 which was a revert of a revert of #8641.