Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Reintroduce graceful deletion with e2e passing #12931

Closed
wants to merge 6 commits into from

Conversation

smarterclayton
Copy link
Contributor

Revert the revert of #9165 which was a revert of a revert of #8641.

@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test failed for commit 5ba01b514f1493386151f0a9291bc18b54e55dad.

@bgrant0607
Copy link
Member

cc @yujuhong

@smarterclayton
Copy link
Contributor Author

I have some more e2e tests, this is still WIP until I've nailed them all.

On Wed, Aug 19, 2015 at 1:27 PM, Brian Grant notifications@github.com
wrote:

cc @yujuhong https://github.com/yujuhong


Reply to this email directly or view it on GitHub
#12931 (comment)
.

Clayton Coleman | Lead Engineer, OpenShift

@smarterclayton smarterclayton changed the title Reintroduce graceful deletion with e2e passing WIP: Reintroduce graceful deletion with e2e passing Aug 19, 2015
@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test failed for commit 5d0a804e805f222c5c1615eaa436378e9475db00.

@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test failed for commit e0de689dd866421f083992d902a5900f65aca445.

@bgrant0607
Copy link
Member

cc @gmarek re. node controller

@smarterclayton
Copy link
Contributor Author

First two commits are in other pulls #12926

This means if List() fails nodes are considered deleted (which is bad)
Prevents a failure of the node controller from deleting the node without
completing the eviction of the node.  As long as there are pods on the
node, the node won't be deleted.
@k8s-bot
Copy link

k8s-bot commented Aug 19, 2015

GCE e2e build/test failed for commit 3061595.

@yujuhong
Copy link
Contributor

One failure:

• Failure [31.586 seconds]
Kubectl client
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:634
  Kubectl describe
  /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:327
    should check if kubectl describe prints relevant information for rc and pods [It]
    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:326

    Aug 19 14:55:11.633: Error running &{/jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/kubernetes/platforms/linux/amd64/kubectl [kubectl --server=https://104.154.53.168 --kubeconfig=/var/lib/jenkins/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/.kube/config describe node pull-e2e-1-minion-sdi5] []  <nil>  format mismatch: DecimalSI vs. BinarySI
     [] <nil> 0xc2081e8840 exit status 1 <nil> true [0xc208050950 0xc208050998 0xc2080509d0] [0xc208050950 0xc208050998 0xc2080509d0] [0xc208050988 0xc2080509c8] [0x682c30 0x682c30] 0xc2082b6480}:
    Command stdout:

    stderr:
    format mismatch: DecimalSI vs. BinarySI



    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/util.go:979

@smarterclayton
Copy link
Contributor Author

It's a flake, I opened a defect. I'm still running e2e tests locally, I
want to verify that I've got something clean. I am also considering
breaking the revert into digestible chunks and only turn on graceful at the
end because the reverts are too much pain for reviewers.

On Aug 19, 2015, at 7:41 PM, Yu-Ju Hong notifications@github.com wrote:

One failure:

• Failure [31.586 seconds]
Kubectl client
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:634
Kubectl describe
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:327
should check if kubectl describe prints relevant information for
rc and pods [It]
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/kubectl.go:326

Aug 19 14:55:11.633: Error running

&{/jenkins-master-data/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/kubernetes/platforms/linux/amd64/kubectl
[kubectl --server=https://104.154.53.168
--kubeconfig=/var/lib/jenkins/jobs/kubernetes-pull-build-test-e2e-gce/workspace@3/.kube/config
describe node pull-e2e-1-minion-sdi5] [] format mismatch:
DecimalSI vs. BinarySI
[] 0xc2081e8840 exit status 1 true [0xc208050950
0xc208050998 0xc2080509d0] [0xc208050950 0xc208050998 0xc2080509d0]
[0xc208050988 0xc2080509c8] [0x682c30 0x682c30] 0xc2082b6480}:
Command stdout:

stderr:
format mismatch: DecimalSI vs. BinarySI



/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/util.go:979


Reply to this email directly or view it on GitHub
#12931 (comment)
.

@smarterclayton
Copy link
Contributor Author

I'm closing this in favor of incremental commits so we can land the non-user impacting code distinct from the actual enabling code and pain caused by rebasing reverts. See links from #9165. Reviews appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants