Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate mock signer for externaljwt tests #129059

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Isolate mock signer for externaljwt tests #129059

merged 1 commit into from
Dec 12, 2024

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 2, 2024 •
edited
Loading

What type of PR is this?

/kind flake

Fixes flake reported in #128190 (comment)

What this PR does / why we need it:

Makes a new mock signer for each instance of the options test to avoid race flakes resetting mock fields between test cases

Switches the mock signer to close gracefully on cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/sig auth

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.32 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.32.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Dec 2 16:45:53 UTC 2024.

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Dec 2, 2024
@liggitt liggitt mentioned this pull request Dec 2, 2024
Merged
@liggitt
Copy link
Member Author

liggitt commented Dec 2, 2024

/assign @ahmedtd
/cc @HarshalNeelkamal

@k8s-ci-robot
Copy link
Contributor

@liggitt: GitHub didn't allow me to request PR reviews from the following users: HarshalNeelkamal.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @ahmedtd
/cc @HarshalNeelkamal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liggitt liggitt force-pushed the externaljwt-flake branch 2 times, most recently from bd4921c to 311d4c7 Compare December 2, 2024 22:01
@liggitt
Copy link
Member Author

liggitt commented Dec 3, 2024

/retest
/clear

@liggitt
Copy link
Member Author

liggitt commented Dec 3, 2024

/skip

@HarshalNeelkamal
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@HarshalNeelkamal: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@liggitt
Copy link
Member Author

liggitt commented Dec 3, 2024

/hold for review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2024
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 3, 2024
@enj
Copy link
Member

enj commented Dec 9, 2024

/assign stlaz

For review.

@liggitt
Copy link
Member Author

liggitt commented Dec 12, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
@stlaz
Copy link
Member

stlaz commented Dec 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ff3e9e459f144ede02efa4ccc52c8513a0a7f88

@liggitt liggitt mentioned this pull request Dec 12, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit 4c2acdd into kubernetes:master Dec 12, 2024
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Dec 12, 2024
k8s-ci-robot added a commit that referenced this pull request Jan 7, 2025
@k8s-ci-robot
Merge pull request #129178 from liggitt/automated-cherry-pick-of-#129…
a40d8d6 
…059-upstream-release-1.32

Automated cherry pick of #129059: Isolate mock signer for externaljwt tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz left review comments

@deads2k deads2k Awaiting requested review from deads2k

@thockin thockin Awaiting requested review from thockin

Assignees

@stlaz stlaz

@ahmedtd ahmedtd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
7 participants
@liggitt @k8s-ci-robot @HarshalNeelkamal @fedebongio @enj @stlaz @ahmedtd