Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: dry-run etcd 3.6 dependency update #128419

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: dry-run etcd 3.6 dependency update #128419

wants to merge 3 commits into from

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 29, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup
/hold POC until etcd 3.6 clients are released

What this PR does / why we need it:

Prove etcd 3.6 dependency updates work properly and drop cloud library dependencies

Which issue(s) this PR fixes:

Fixes #113366

Special notes for your reviewer:

-Direct Dependencies: 180 
-Transitive Dependencies: 329 
-Total Dependencies: 365 
+Direct Dependencies: 179 
+Transitive Dependencies: 208 
+Total Dependencies: 244

Does this PR introduce a user-facing change?

NONE

/cc @dims
/area code-organization

/cc @serathius
for visibility to how etcd 3.6 client library updates will help clean up k8s deps (lets us pick up etcd-io/etcd#16595 🎉 )

/cc @princepereira
for visibility to hnslib use of opencensus.io pulling in super old grpc / genproto dep (xref #127713 (comment) - fixed in #128841)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dims October 29, 2024 16:51
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added the area/code-organization Issues or PRs related to kubernetes code organization label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

@liggitt: GitHub didn't allow me to request PR reviews from the following users: princepereira.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind cleanup
/hold POC until etcd 3.6 clients are released

What this PR does / why we need it:

Prove etcd 3.6 dependency updates work properly and drop cloud library dependencies

Which issue(s) this PR fixes:

Fixes #113366

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/cc @dims
/area code-organization

/cc @serathius
for visibility to how etcd 3.6 client library updates will help clean up k8s deps

/cc @princepereira
for visibility to hnslib use of opencensus.io pulling in super old grpc / genproto dep

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubeadm area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 29, 2024
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Oct 29, 2024
@liggitt liggitt mentioned this pull request Oct 29, 2024
Closed
@serathius
Copy link
Contributor

cc @ahrtr

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2024
@liggitt liggitt mentioned this pull request Nov 5, 2024
Open
38 tasks
@aojea
Copy link
Member

aojea commented Nov 12, 2024

/cc @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea November 12, 2024 04:28
@liggitt liggitt mentioned this pull request Nov 18, 2024
Merged
@pohly
Copy link
Contributor

pohly commented Nov 19, 2024

/remove-wg device-management

@k8s-ci-robot k8s-ci-robot removed the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Nov 19, 2024
@liggitt
WIP: bump etcd deps to 3.6 alpha
237789c 
hack/pin-dependency.sh go.etcd.io/etcd/api/v3 main
hack/pin-dependency.sh go.etcd.io/etcd/client/pkg/v3 main
hack/pin-dependency.sh go.etcd.io/etcd/client/v3 main
hack/pin-dependency.sh go.etcd.io/etcd/pkg/v3 main
hack/pin-dependency.sh go.etcd.io/etcd/server/v3 main
hack/update-vendor.sh
@liggitt
Clean up unwanted dependencies
820e57f
@liggitt
Fix kubeadm etcd client interface
26dde8a
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Nov 19, 2024
liggitt
liggitt commented Nov 19, 2024
View reviewed changes
staging/src/k8s.io/apiextensions-apiserver/go.mod
github.com/inconshreveable/mousetrap v1.1.0 // indirect
github.com/jonboulle/clockwork v0.4.0 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/klauspost/compress v1.17.9 // indirect
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is the only caller that requires us to vendor this, and intends to switch to stdlib once a zstd impl is merged

@k8s-ci-robot
Copy link
Contributor

@liggitt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-windows-master 26dde8a link false /test pull-kubernetes-e2e-capz-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@serathius serathius Awaiting requested review from serathius

@aojea aojea Awaiting requested review from aojea

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubeadm area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
SIG Auth
Status: Needs Triage
SIG CLI
Status: Needs Triage
SIG Node: Dynamic Resource Allocation
Archived in project
SIG Node: code and documentation PRs
Status: not-only-sig-node
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Untangle genproto / cloud.google.com/go dependencies
5 participants
@liggitt @k8s-ci-robot @serathius @aojea @pohly