Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove sig/api-machinery from OWNERS files that sig/etcd owns #128213

Merged
merged 1 commit into from
Oct 24, 2024
Merged

chore: remove sig/api-machinery from OWNERS files that sig/etcd owns #128213

merged 1 commit into from
Oct 24, 2024

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Oct 20, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes sig/api-machinery from OWNERS files that likely sig/etcd should solely own. This is related to the issue #127336 that was filed during the sig/api-machinery bi-weekly bugscrub. The gist of this issue is that sig/api-machinery is flagged on PRs that should likely solely belong to sig/etcd. Fully "fixing" this issue would also likely include using OWNERS filters: for top level directories and setting specific files to be delegated to sig/etcd (for example - hack/lib/etcd.sh, etc.) As such this PR is only part of the solution to #127336. For additional context on the sig/etcd label and OWNERS, see the original PR that added the sig/etcd label to OWNERS here: #125679

Which issue(s) this PR fixes:

Part of #127336

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig api-machinery
/sig etcd

/triage approved

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. labels Oct 20, 2024
@k8s-ci-robot
Copy link
Contributor

@aaron-prindle: The label(s) triage/approved cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR removes sig/api-machinery from OWNERS files that likely sig/etcd should solely own. This is related to the issue #127336 that was files during the sig/api-machinery bi-weekly bugscrub. The gist of this issue is that sig/api-machinery is flagged on PRs that should likely solely belong to sig/etcd. Fully "fixing" this issue would also likely include using OWNERS filters: for top level directories and setting specific files to be delegated to sig/etcd (for example - hack/lib/etcd.sh, etc.) As such this PR is only part of the solution to #127336. For additional context on the sig/etcd label and OWNERS, see the original PR that added the sig/etcd label to OWNERS here: #125679

Which issue(s) this PR fixes:

Part of #127336

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig api-machinery
/sig etcd

/triage approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/release-eng Issues or PRs related to the Release Engineering subproject labels Oct 20, 2024
@aaron-prindle
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 20, 2024
@dims
Copy link
Member

dims commented Oct 20, 2024

/assign @serathius

@pacoxu
Copy link
Member

pacoxu commented Oct 21, 2024

Probably we can add a etcd team in the OWNER_ALIASES file.

@serathius
Copy link
Contributor

/lgtm
/approve

/hold
for @jpbetz to confirm from sig api-machinery side

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d2a5d93862c598bef0b408a67ee6c419b0bdbd37

@jpbetz
Copy link
Contributor

jpbetz commented Oct 24, 2024

/lgtm
/approve

@dims
Copy link
Member

dims commented Oct 24, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle, dims, jpbetz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@serathius
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0f549a9 into kubernetes:master Oct 24, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@serathius serathius Awaiting requested review from serathius

Assignees

@dims dims

@jpbetz jpbetz

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@aaron-prindle @k8s-ci-robot @dims @pacoxu @serathius @jpbetz