Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing hcsshim library with new hnslib library. #128045

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Replacing hcsshim library with new hnslib library. #128045

merged 1 commit into from
Oct 14, 2024

Conversation

princepereira
Copy link
Contributor

This commit imports new hnslib library for all hns references in k/k instead of having to import whole of hcsshim which brings in unwanted dependencies. hnslib holds all the hns related code with much less dependencies.

#127713

What type of PR is this?

/kind feature

What this PR does / why we need it:

This commit aims at removing import of whole of hcsshim .

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

-->

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubelet sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 14, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and feiskyer October 14, 2024 06:04
@princepereira
Copy link
Contributor Author

New PR raised as the existing pr (#127713) has some merge conflicts

@princepereira
Copy link
Contributor Author

/cc @dims , @kiashok , @sbangari , @jsturtevant , @marosset

Please review the new PR.

@pacoxu
Copy link
Member

pacoxu commented Oct 14, 2024 •
edited
Loading

You may just force push this branch to hnslib-import.

  • to refresh that PR.
### first you are in this branch `ppereira-hnslib-import`
### 1. delete the old branch
git branch -D hnslib-import
### 2. rename current branch to the original name 
git branch -m hnslib-import
### 3. force push the branch
git push origin hnslib-import -f

Notice: if you close the PR and force-pushed to the branch, github will not allow you to reopen it. You can forch push to the opened PR related branch directly.

@dims
Copy link
Member

dims commented Oct 14, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2024
@dims
Copy link
Member

dims commented Oct 14, 2024

@pacoxu the other PR was from @kiashok so @princepereira may not have enough rights to push to that repo/branch. So this is ok. @kiashok indicated earlier that they will be on vacation.

@dims
Copy link
Member

dims commented Oct 14, 2024

wowza! still good

-Direct Dependencies: 189 
-Transitive Dependencies: 379 
-Total Dependencies: 416 
+Direct Dependencies: 188 
+Transitive Dependencies: 333 
+Total Dependencies: 371 
 Max Depth Of Dependencies: 25 
 All dependencies:

@dims
Copy link
Member

dims commented Oct 14, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d0355e119d79e67f9331fce09f655f80d2c39b71

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@dims
Copy link
Member

dims commented Oct 14, 2024

@princepereira please update hack/unwanted-dependencies.json (you can iterate locally using hack/lint-dependencies.sh)

@princepereira princepereira force-pushed the ppereira-hnslib-import branch from 73d5e38 to 3448455 Compare October 14, 2024 17:44
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, princepereira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@princepereira
Copy link
Contributor Author

@princepereira please update hack/unwanted-dependencies.json (you can iterate locally using hack/lint-dependencies.sh)

Thanks @dims . Addressed.

@princepereira princepereira reopened this Oct 14, 2024
@dims
Copy link
Member

dims commented Oct 14, 2024

/retest

@dims
Copy link
Member

dims commented Oct 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b8b456008e371cf1f258096444371dca487d605f

@dims
Copy link
Member

dims commented Oct 14, 2024

/retest

@dims
Copy link
Member

dims commented Oct 14, 2024

/skip

@k8s-ci-robot k8s-ci-robot merged commit 9f09c55 into kubernetes:master Oct 14, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 14, 2024
@jsturtevant jsturtevant mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Status: Done
[sig-windows] PR tracking
Status: Done
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
5 participants
@princepereira @k8s-ci-robot @pacoxu @dims @k8s-triage-robot