Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #127285: Update etcd from v3.5.15 to v3.5.16 #127283: Build etcd image of v3.5.16 #127979

Closed
wants to merge 2 commits into from
Closed

Automated cherry pick of #127285: Update etcd from v3.5.15 to v3.5.16 #127283: Build etcd image of v3.5.16 #127979

wants to merge 2 commits into from

Conversation

bzsuni
Copy link
Contributor

@bzsuni bzsuni commented Oct 10, 2024 •
edited
Loading

Cherry pick of #127285 #127283 on release-1.28.

#127285: Update etcd from v3.5.15 to v3.5.16
#127283: Build etcd image of v3.5.16

For details on the cherry pick process, see the cherry pick requests page.

none

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 10, 2024
@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 10, 2024
@Jefftree
Copy link
Member

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 10, 2024
@bzsuni bzsuni force-pushed the automated-cherry-pick-of-#127285-#127283-upstream-release-1.28 branch from 71cb5ba to 4b824ef Compare October 11, 2024 01:58
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 11, 2024
@dims
Copy link
Member

dims commented Oct 11, 2024

/assign @serathius

@bzsuni
Copy link
Contributor Author

bzsuni commented Oct 11, 2024

/retest-required

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 15, 2024
@bzsuni bzsuni force-pushed the automated-cherry-pick-of-#127285-#127283-upstream-release-1.28 branch from 4b824ef to 9789799 Compare November 7, 2024 09:37
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@bzsuni
Update etcd from v3.5.15 to v3.5.16
d4b4aba 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni bzsuni force-pushed the automated-cherry-pick-of-#127285-#127283-upstream-release-1.28 branch from 9789799 to beb3cef Compare November 7, 2024 09:46
@bzsuni
Build etcd image v3.5.16
966bb20 
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@bzsuni bzsuni force-pushed the automated-cherry-pick-of-#127285-#127283-upstream-release-1.28 branch from beb3cef to 966bb20 Compare November 7, 2024 10:47
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2024
@bzsuni
Copy link
Contributor Author

bzsuni commented Nov 8, 2024

/test pull-kubernetes-integration

2 similar comments
@bzsuni
Copy link
Contributor Author

bzsuni commented Nov 8, 2024

/test pull-kubernetes-integration

@bzsuni
Copy link
Contributor Author

bzsuni commented Nov 8, 2024

/test pull-kubernetes-integration

@bzsuni
Copy link
Contributor Author

bzsuni commented Nov 8, 2024

@dims
For approval and lgtm please

@dims
Copy link
Member

dims commented Nov 8, 2024

/approve
/assign @serathius

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bzsuni, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@mepi262
Copy link

mepi262 commented Dec 5, 2024

@chendave @deads2k @dims @pacoxu @serathius
Would you tell me any update on this pull request?

@pacoxu
Copy link
Member

pacoxu commented Dec 5, 2024

#128772 is in progress and not merged as the code freeze of v1.32.

  • This CR is still valid before that.
  • However, we can wait for the v3.5.17 cherry-pick after the v1.32 release(which is before the patch release this month.)

@mepi262
Copy link

mepi262 commented Dec 5, 2024

@pacoxu
Thank you for your reply!
I recognize this pull request's destination branch is release-1.28 and it's EOL.
Under this situation, Is this pull request still valid?

@pacoxu
Copy link
Member

pacoxu commented Dec 5, 2024

Thanks for clarification.
/close

@k8s-ci-robot
Copy link
Contributor

@pacoxu: Closed this PR.

In response to this:

Thanks for clarification.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendave chendave Awaiting requested review from chendave

@deads2k deads2k Awaiting requested review from deads2k

@dims dims Awaiting requested review from dims

@pacoxu pacoxu Awaiting requested review from pacoxu

@serathius serathius Awaiting requested review from serathius

Assignees

@dims dims

@pacoxu pacoxu

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
9 participants
@bzsuni @k8s-ci-robot @Jefftree @dims @pacoxu @seans3 @fedebongio @mepi262 @serathius