Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

• ✅login: 985492783 / (59d2c9a)

Welcome @985492783!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @985492783. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 985492783
Once this PR has been reviewed and has the lgtm label, please assign cheftako, danwinship, sanposhiho for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

/cc @sanposhiho

/ok-to-test
/remove-kind feature
/kind cleanup

FYI #125196 (comment)

It seems to be about whether to rely on a third-party ctx modification. If a change is needed, it might be better to make the change in a single PR. If no changes are needed, perhaps we should keep things as they are.

I think this PR is an absolute enhancement and compatible with previous versions

1. The new default context allows my kube-controller-manager to safely exit
2. Compatible with the current version of third-party relied
3. Allow special contexts to be passed in, such as those that can be manually closed

Although the community should not be held accountable to the third-party library, I believe this ability should be exposed, just like kube-apiServer, isn't it?

I think this PR is an absolute enhancement and compatible with previous versions

1. The new default context allows my kube-controller-manager to safely exit

2. Compatible with the current version of third-party relied

3. Allow special contexts to be passed in, such as those that can be manually closed

Although the community should not be held accountable to the third-party library, I believe this ability should be exposed, just like kube-apiServer, isn't it?

#125196 (comment)

We have already discussed similar issues in this comment. I am fine with either option, but we should consider the opinions of other reviewers.

/cc @aojea

/triage accepted

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale