Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some note about generated file to unversioned_feature_list.yaml& versioned_feature_list.yaml #127297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add some note about generated file to unversioned_feature_list.yaml& versioned_feature_list.yaml #127297

wants to merge 1 commit into from

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Sep 11, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

for tell people that unversioned_feature_list.yaml&versioned_feature_list.yaml is updated automatically and not edited manually
xref #127185 (comment)
/assign @Jefftree

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @liangyuanpeng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 11, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2024
Jefftree
Jefftree reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@Jefftree Jefftree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

hack/update-featuregates.sh Outdated Show resolved Hide resolved
test/featuregates_linter/cmd/feature_gates.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2024
@Jefftree
Copy link
Member

/assign @BenTheElder @jpbetz

@Jefftree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c33f465761278d5b6aaf2fbf050801be9f968072

@seans3
Copy link
Contributor

seans3 commented Sep 12, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 12, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Sep 19, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpbetz, liangyuanpeng
Once this PR has been reviewed and has the lgtm label, please ask for approval from bentheelder. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liangyuanpeng
add some note about generated file to unversioned_feature_list.yaml& …
c5248b4 
…versioned_feature_list.yaml

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

liangyuanpeng
liangyuanpeng commented Sep 24, 2024
View reviewed changes
Copy link
Contributor Author

@liangyuanpeng liangyuanpeng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased to resolve conflict.

Needs approval from an approver in each of these files:
hack/OWNERS
test/featuregates_linter/OWNERS [jpbetz]
test/featuregates_linter/test_data/OWNERS [jpbetz]

looking for approval for hack
cc @liggitt @BenTheElder thank you!

test/featuregates_linter/cmd/feature_gates.go Show resolved Hide resolved
BenTheElder
BenTheElder reviewed Sep 24, 2024
View reviewed changes
hack/update-featuregates.sh
@@ -28,3 +28,5 @@ source "${KUBE_ROOT}/hack/lib/init.sh"
cd "${KUBE_ROOT}"

go run test/featuregates_linter/main.go feature-gates update
sed -i '1i\# This is a generated file. Do not edit directly.\n# Run hack/update-featuregates.sh to update it.' test/featuregates_linter/test_data/versioned_feature_list.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be emitted by go run test/featuregates_linter/main.go feature-gates update, so we can have verify confirm that these lines exist?

kubernetes/hack/verify-featuregates.sh

Line 31 in e9cde03

go run test/featuregates_linter/main.go feature-gates verify

Right now we won't fail presubmit if someone edits these lines.

Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me understand what you mean, you mean to put the text lines into the update and verify logic as well? Even though it has nothing to do with featuregate.

How is the way people modify text in hack/update-featuregates.sh different from how they modify text in code?

The reason I didn't put the logic into the code is because I didn't want to make the code more complicated, but I'd be happy to do that if necessary.

kubernetes/test/featuregates_linter/cmd/feature_gates.go

Lines 162 to 166 in 99ff62e

data, err := yaml.Marshal(featureList)
if err != nil {
return err
}
return os.WriteFile(filePath, data, 0644)

Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the way people modify text in hack/update-featuregates.sh different from how they modify text in code?

One place that makes sense is let go run test/featuregates_linter/main.go feature-gates verify working for featuregate and text lines.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dims dims added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@liggitt liggitt Awaiting requested review from liggitt

@logicalhan logicalhan Awaiting requested review from logicalhan

@Jefftree Jefftree Awaiting requested review from Jefftree

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@BenTheElder BenTheElder

@Jefftree Jefftree

Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@liangyuanpeng @k8s-ci-robot @Jefftree @seans3 @jpbetz @BenTheElder @dims