Remove aggregated v2beta1 type usage #127280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
area/test
sig/api-machinery
Jefftree
force-pushed
the
remove-v2beta1-agg-discovery
branch
2 times, most recently
from
f9dbfb3 to
541f093
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jefftree The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/code-generation
kind/api-change
Jefftree
force-pushed
the
remove-v2beta1-agg-discovery
branch
2 times, most recently
from
021beec to
fc8a8dd
Compare
Jefftree
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
Jefftree
force-pushed
the
remove-v2beta1-agg-discovery
branch
from
fc8a8dd to
14d3ee3
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dims
added
the
lifecycle/rotten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
Remove the deprecated v2beta1 apidiscovery.k8s.io type.
v2beta1 has been deprecated since 1.30 and there should be no skew issues as we are serving v2beta1 in both v1.30 and v1.31 and all 1.30+ clients are able to download both v2beta1 and v2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/triage accepted