Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove attachable volume limit from node's status capacity #126924

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Remove attachable volume limit from node's status capacity #126924

merged 1 commit into from
Oct 4, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented Aug 26, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

A follow-up of #124003

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed attachable volume limits from the capacity of the node for the following volume type when the kubelet is started, affecting the following volume types when the corresponding csi driver is installed:
- `awsElasticBlockStore` for `ebs.csi.aws.com`
- `azureDisk` for `disk.csi.azure.com`
- `gcePersistentDisk` for `pd.csi.storage.googleapis.com`
- `cinder` for `cinder.csi.openstack.org`
- `csi`
But it's still enforced using a limit in CSINode objects.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 26, 2024
@carlory
Copy link
Member Author

carlory commented Aug 26, 2024

/cc @jsafrane

@k8s-ci-robot k8s-ci-robot requested a review from jsafrane August 26, 2024 16:37
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2024
@carlory
Copy link
Member Author

carlory commented Sep 13, 2024

/cc @msau42

Can you take a look when you have time?

@k8s-ci-robot k8s-ci-robot requested a review from msau42 September 13, 2024 17:25
jsafrane
jsafrane reviewed Sep 17, 2024
View reviewed changes
pkg/volume/csi/nodeinfomanager/nodeinfomanager.go Outdated
@@ -112,6 +112,7 @@ func (nim *nodeInfoManager) InstallCSIDriver(driverName string, driverNodeID str
}

nodeUpdateFuncs := []nodeUpdateFunc{
removeMaxAttachLimit(driverName), // remove in 1.34
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the comment with a reason why should it be removed in 1.34.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@jsafrane
Copy link
Member

The release note says awsElasticBlockStore, azureDisk, gcePersistentDisk, and cinder limits are removed, but the code removes just a single CSI driver from the list.

@carlory
Copy link
Member Author

carlory commented Sep 18, 2024 •
edited
Loading

@jsafrane The release note may not include the details of the change. For end users, once the kubelet is restarted or upgraded to 1.32, all the CSI drivers will be re-registered. during the re-registration, the volume limits in node status will be removed if those specified CSI driver is still installed on the cluster.

If the CSI driver has already been uninstalled, the node status volume limits will also be removed. It's an existing behavior that was not introduced by this PR.

edit: the release note is updated.

@jsafrane
Copy link
Member

jsafrane commented Oct 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@jsafrane
Copy link
Member

jsafrane commented Oct 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f1799a5e19225c6d4dfc9b53ebcca0a500dc0682

@jsafrane
Copy link
Member

jsafrane commented Oct 4, 2024

@carlory still, please update the release note to emphasize the limit is removed from Node, but it's still enforced using a limit in CSINode objects.

@k8s-ci-robot k8s-ci-robot merged commit 65bc7c0 into kubernetes:master Oct 4, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 4, 2024
@carlory carlory deleted the volumelimit branch October 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@mattcary mattcary Awaiting requested review from mattcary

@xing-yang xing-yang Awaiting requested review from xing-yang

@msau42 msau42 Awaiting requested review from msau42

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@carlory @k8s-ci-robot @jsafrane