@oxxenix: GitHub didn't allow me to request PR reviews from the following users: kubernetes/wg-structured-logging-reviews.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Hi @oxxenix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

/triage accepted
/cc @pohly

/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e

/test pull-kubernetes-node-crio-cgrpv2-e2e

/test pull-kubernetes-node-crio-e2e

/retest

@kannon92 @saschagrunert @haircommander not sure why the cgroups v2 crio job, pull-kubernetes-node-crio-cgrpv2-e2e, is failing for this PR.

@harche I've triggered it for my test PR #120459. Let's see if it fails or not.

@harche

@oxxenix @bart0sh it would be interesting to know if changing to contextual logging has any impact on the performance or resource utilization.

Any suggestions how to do it?

@harshe crio-cgrpv2-e2e failed the same way as some of the runs triggered by this PR:

• job run triggered by this PR: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-node-crio-cgrpv2-e2e/1834652050592370688
• job run triggered by my test PR: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/120459/pull-kubernetes-node-crio-cgrpv2-e2e/1834680409342873600

So, it seems unrelated to the changes made by this PR.

/skip

I agree the failures look unrelated, I'm checking if we have to fix anything for the cgroupv2 test in #127381

/lgtm

@pohly can you approve it? It looks like it still requires approval from hack/ owners.

LGTM label has been added.

/approve

@mrunalp @SergeyKanzhelev please, approve. You're our last hope :)

migrate pkg/kubelet/pleg to contextual logging

Is there a good documentation on this? Since this code now will have a different pattern than other code - we need to make sure we can point to the migration docs explaining how things work and which type of logging to use when.

Also, what would be an effect if old-style logs are used alongside the contextual logging? I am trying to see if this code calls into anything that will use old-style logging. Is it just the context will be missing?

Sure, there is a documentation on this:

• KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging
• Blog post about contextual logging in 1.24: https://www.kubernetes.dev/blog/2022/05/25/contextual-logging/
• Blog post about contextual logging in 1.29: https://kubernetes.io/blog/2023/12/20/contextual-logging-in-kubernetes-1-29/

It's ongoing process and SIG-Node is already participating in it. All Kubelet code has been moved to structured logging and move to contextual logging is a logical continuation of this process.

old and new style components should co-exist and don't influence each other, at least to my knowledge.

Is it just the context will be missing?

The code that doesn't use contextual logging will keep using structured logging I believe. Logging prefixes will be different in some cases, but only for the component that switched to contextual logging.

FWIW a lot of k/k code already moved to contextual logging, for example DRA Kubelet code and it works just fine.

/release-note-none

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oxxenix, pohly, saschagrunert, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@oxxenix: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

/retest