Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consume cpu function to Resource Consumer #12517

Merged
merged 2 commits into from
Aug 12, 2015

Conversation

socaa
Copy link

@socaa socaa commented Aug 11, 2015

Part of #11570

@k8s-bot
Copy link

k8s-bot commented Aug 11, 2015

GCE e2e build/test passed for commit 44c5da4f0b4e8dd48024ab668fcdd94edbbe78d4.


var (
milicores = flag.Int("milicores", 0, "milicores number")
durationSec = flag.Int("durationSec", 0, "duration time in seconds")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falags should be in dash notation, i.e: "duration-sec"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@socaa
Copy link
Author

socaa commented Aug 11, 2015

PTAL


func main() {
flag.Parse()
// converte milicores to percentage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, should be "convert"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k8s-bot
Copy link

k8s-bot commented Aug 11, 2015

GCE e2e build/test passed for commit 77b08da.

@jszczepkowski
Copy link
Contributor

LGTM

@piosz
Copy link
Member

piosz commented Aug 12, 2015

You need to add bitbucket.org/bertimus9/systemstat to the godeps

@socaa
Copy link
Author

socaa commented Aug 12, 2015

PTAL

@k8s-bot
Copy link

k8s-bot commented Aug 12, 2015

GCE e2e build/test passed for commit af74d03871a2d5162380a1f3e5776c8a55f781cd.

@piosz piosz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2015
@k8s-bot
Copy link

k8s-bot commented Aug 12, 2015

GCE e2e build/test passed for commit e48d4d7.

piosz added a commit that referenced this pull request Aug 12, 2015
Added consume cpu function to Resource Consumer
@piosz piosz merged commit 50a5c57 into kubernetes:master Aug 12, 2015
@piosz piosz mentioned this pull request Aug 14, 2015
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants