-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added consume cpu function to Resource Consumer #12517
Conversation
GCE e2e build/test passed for commit 44c5da4f0b4e8dd48024ab668fcdd94edbbe78d4. |
|
||
var ( | ||
milicores = flag.Int("milicores", 0, "milicores number") | ||
durationSec = flag.Int("durationSec", 0, "duration time in seconds") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
falags should be in dash notation, i.e: "duration-sec"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
PTAL |
|
||
func main() { | ||
flag.Parse() | ||
// converte milicores to percentage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, should be "convert"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
GCE e2e build/test passed for commit 77b08da. |
LGTM |
You need to add bitbucket.org/bertimus9/systemstat to the godeps |
PTAL |
GCE e2e build/test passed for commit af74d03871a2d5162380a1f3e5776c8a55f781cd. |
GCE e2e build/test passed for commit e48d4d7. |
Added consume cpu function to Resource Consumer
Part of #11570