Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: don't set crbResult to nil if the error is already exists #122900

Closed
wants to merge 1 commit into from
Closed

kubeadm: don't set crbResult to nil if the error is already exists #122900

wants to merge 1 commit into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 22, 2024 •
edited
Loading

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

error handling crb existing

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#3000 #122901

Special notes for your reviewer:

#122893 was merged yesterday to fix the test with #122892.

If EnsureAdminClusterRoleBindingImpl now works as expected, we should handle the existing error in post upgrade progress to make it pass.

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@pacoxu pacoxu force-pushed the fix-kubeadm-existing-crb branch from e9b969a to c35b12a Compare January 22, 2024 06:32
@pacoxu
Copy link
Member Author

pacoxu commented Jan 22, 2024

/cc @danwinship @SataQiu
/uncc @chendave

@k8s-ci-robot k8s-ci-robot requested review from danwinship and SataQiu and removed request for chendave January 22, 2024 06:35
@pacoxu pacoxu mentioned this pull request Jan 22, 2024
Merged
@pacoxu
Copy link
Member Author

pacoxu commented Jan 22, 2024

I prefer the fix in #122901.

kubernetes/cmd/kubeadm/app/phases/kubeconfig/kubeconfig.go

Lines 698 to 702 in a07b1aa

if apierrors.IsAlreadyExists(err) {
// This should not happen, as the previous "create" call that uses
// the admin.conf should have passed. Return the error.
return true, err
}

With #122893, the code above is not correct anymore.

@danwinship danwinship mentioned this pull request Jan 22, 2024
Closed
@danwinship
Copy link
Contributor

If EnsureAdminClusterRoleBindingImpl now works as expected

Yeah, I think it now doesn't work as expected; I filed #122906 to fix that

@pacoxu
Copy link
Member Author

pacoxu commented Jan 22, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@pacoxu: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 Awaiting requested review from neolit123

@danwinship danwinship Awaiting requested review from danwinship

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm-kinder-upgrade-*-1-29-latest failed for existing ClusterRoleBinding
3 participants
@pacoxu @k8s-ci-robot @danwinship