Remove unnecessary error catch in scheduling failure #121981

utam0k · 2023-11-21T12:26:52Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

~~With apierrors, kind is plural. It is likely that these are not working well because they have not been made appropriate.~~
Remove unnecessary error catch in scheduling failure.

Which issue(s) this PR fixes:

Fixes #121980

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2023-11-21T12:27:03Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-11-21T12:27:04Z

Hi @utam0k. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…missing Node Signed-off-by: utam0k <k0ma@utam0k.jp>

sanposhiho · 2023-11-26T06:53:52Z

pkg/scheduler/schedule_one.go

@@ -987,7 +987,7 @@ func (sched *Scheduler) handleSchedulingFailure(ctx context.Context, fwk framewo
 		logger.V(2).Info("Unable to schedule pod; no fit; waiting", "pod", klog.KObj(pod), "err", errMsg)
 	} else if apierrors.IsNotFound(err) {
 		logger.V(2).Info("Unable to schedule pod, possibly due to node not found; waiting", "pod", klog.KObj(pod), "err", errMsg)
-		if errStatus, ok := err.(apierrors.APIStatus); ok && errStatus.Status().Details.Kind == "node" {
+		if errStatus, ok := err.(apierrors.APIStatus); ok && (errStatus.Status().Details.Kind == "nodes" || errStatus.Status().Details.Kind == "node") { // Ususally `node` is used as the Kind, but `nodes` is also possible.


Looks really weird, please explain when which one is used. I'd like to seek a possible solution where only one kind is used here.

At least, apierrors uses resource name(nodes) as a kind in StatusError.

kubernetes/staging/src/k8s.io/apimachinery/pkg/api/errors/errors.go

Lines 144 to 156 in d61cbac

func NewNotFound(qualifiedResource schema.GroupResource, name string) *StatusError {

return &StatusError{metav1.Status{

Status: metav1.StatusFailure,

Code: http.StatusNotFound,

Reason: metav1.StatusReasonNotFound,

Details: &metav1.StatusDetails{

Group: qualifiedResource.Group,

Kind: qualifiedResource.Resource,

Name: name,

},

Message: fmt.Sprintf("%s %q not found", qualifiedResource.String(), name),

}}

}

I honestly don't know if there is room to plant StatusError from elsewhere. node is nuanced enough that there may possibly be errors transmitted from user plug-ins, etc., which may not be needed.

I don't like "keep it because someone may use it" in general. We want to catch non-found errors from kube-apiserver, so if kube-apiserver emits errors with "nodes", then supporting "nodes" only should be enough.

👌
d3def07

sanposhiho

/ok-to-test

Signed-off-by: utam0k <k0ma@utam0k.jp>

alculquicondor · 2023-11-28T14:34:01Z

Failures look legit

utam0k · 2023-11-29T11:36:51Z

Failures look legit

Ops.. I'll check them

Signed-off-by: utam0k <k0ma@utam0k.jp>

utam0k · 2023-11-29T13:32:04Z

/retest-required

alculquicondor · 2023-11-29T18:34:40Z

/remove-kind bug
/kind cleanup

alculquicondor · 2023-11-29T18:35:23Z

/lgtm
/approve

k8s-ci-robot · 2023-11-29T18:35:31Z

LGTM label has been added.

Git tree hash: 79ec6a4cb543557a3f717a5978b2cb428be4a312

k8s-ci-robot · 2023-11-29T18:35:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, utam0k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/scheduler/OWNERS~~ [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Huang-Wei · 2023-11-30T17:49:17Z

/label tide/merge-method-squash

* Deleted from the cache in the handling of scheduling failures due to missing Node Signed-off-by: utam0k <k0ma@utam0k.jp> * Support only `nodes` * Remove unnecessary error catch Signed-off-by: utam0k <k0ma@utam0k.jp> * Fix a build error Signed-off-by: utam0k <k0ma@utam0k.jp> * Fix a build error Signed-off-by: utam0k <k0ma@utam0k.jp> --------- Signed-off-by: utam0k <k0ma@utam0k.jp>

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 21, 2023

k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 21, 2023

k8s-ci-robot requested review from damemi and denkensk November 21, 2023 12:28

utam0k mentioned this pull request Nov 21, 2023

Not deleted from the cache in the handling of scheduling failures due to missing Node #121980

Closed

utam0k changed the title ~~Deleted from the cache in the handling of scheduling failures due to …~~ Deleted from the cache in the handling of scheduling failures due to missing Node Nov 26, 2023

utam0k changed the title ~~Deleted from the cache in the handling of scheduling failures due to missing Node~~ Delete a missing node from the cache in the handling of scheduling failures Nov 26, 2023

Deleted from the cache in the handling of scheduling failures due to …

f4de4ac

…missing Node Signed-off-by: utam0k <k0ma@utam0k.jp>

utam0k changed the title ~~Delete a missing node from the cache in the handling of scheduling failures~~ Delete properly a missing node from the cache in the handling of scheduling failures Nov 26, 2023

utam0k force-pushed the issue-121980 branch from 0cedd4c to f4de4ac Compare November 26, 2023 06:01

utam0k changed the title ~~Delete properly a missing node from the cache in the handling of scheduling failures~~ Properly delete a missing node from the cache in the handling of scheduling failures Nov 26, 2023

utam0k marked this pull request as ready for review November 26, 2023 06:03

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2023

k8s-ci-robot requested review from chendave and sanposhiho November 26, 2023 06:03

sanposhiho reviewed Nov 26, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2023

Remove unnecessary error catch

ad47cba

Signed-off-by: utam0k <k0ma@utam0k.jp>

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2023

utam0k changed the title ~~Properly delete a missing node from the cache in the handling of scheduling failures~~ Remove unnecessary error catch in scheduling failure Nov 28, 2023

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 28, 2023

utam0k requested a review from sanposhiho November 28, 2023 11:37

Fix a build error

3eb41f9

Signed-off-by: utam0k <k0ma@utam0k.jp>

Fix a build error

c576fe9

Signed-off-by: utam0k <k0ma@utam0k.jp>

utam0k requested a review from alculquicondor November 29, 2023 12:35

k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Nov 29, 2023

k8s-ci-robot assigned alculquicondor Nov 29, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 30, 2023

k8s-ci-robot merged commit 0191662 into kubernetes:master Dec 14, 2023
14 checks passed

k8s-ci-robot added this to the v1.30 milestone Dec 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unnecessary error catch in scheduling failure #121981

Remove unnecessary error catch in scheduling failure #121981

utam0k commented Nov 21, 2023 •

edited

Loading

k8s-ci-robot commented Nov 21, 2023

k8s-ci-robot commented Nov 21, 2023

sanposhiho Nov 26, 2023 •

edited

Loading

utam0k Nov 26, 2023

sanposhiho Nov 26, 2023

utam0k Nov 27, 2023

sanposhiho left a comment

alculquicondor commented Nov 28, 2023

utam0k commented Nov 29, 2023

utam0k commented Nov 29, 2023

alculquicondor commented Nov 29, 2023

alculquicondor commented Nov 29, 2023

k8s-ci-robot commented Nov 29, 2023

k8s-ci-robot commented Nov 29, 2023

Huang-Wei commented Nov 30, 2023

	func NewNotFound(qualifiedResource schema.GroupResource, name string) *StatusError {
	return &StatusError{metav1.Status{
	Status: metav1.StatusFailure,
	Code: http.StatusNotFound,
	Reason: metav1.StatusReasonNotFound,
	Details: &metav1.StatusDetails{
	Group: qualifiedResource.Group,
	Kind: qualifiedResource.Resource,
	Name: name,
	},
	Message: fmt.Sprintf("%s %q not found", qualifiedResource.String(), name),
	}}
	}

Remove unnecessary error catch in scheduling failure #121981

Remove unnecessary error catch in scheduling failure #121981

Conversation

utam0k commented Nov 21, 2023 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Nov 21, 2023

k8s-ci-robot commented Nov 21, 2023

sanposhiho Nov 26, 2023 • edited Loading

Choose a reason for hiding this comment

utam0k Nov 26, 2023

Choose a reason for hiding this comment

sanposhiho Nov 26, 2023

Choose a reason for hiding this comment

utam0k Nov 27, 2023

Choose a reason for hiding this comment

sanposhiho left a comment

Choose a reason for hiding this comment

alculquicondor commented Nov 28, 2023

utam0k commented Nov 29, 2023

utam0k commented Nov 29, 2023

alculquicondor commented Nov 29, 2023

alculquicondor commented Nov 29, 2023

k8s-ci-robot commented Nov 29, 2023

k8s-ci-robot commented Nov 29, 2023

Huang-Wei commented Nov 30, 2023

utam0k commented Nov 21, 2023 •

edited

Loading

sanposhiho Nov 26, 2023 •

edited

Loading