Added exporting autoscaling metrics in Heapster config #12103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 2bf447c. |
|
LGTM. @piosz we should consider adding an e2e test to ensure that the GCM backend works and has the necessary data. |
piosz
added
the
lgtm
|
@k8s-bot test this [testing build queue, sorry for the noise] |
|
Don't you need to update the version of the addon when you change its config so the addon-controller will pick up the change on upgrade? |
|
GCE e2e build/test passed for commit 2bf447c. |
alex-mohr
added a commit
that referenced
this pull request
Aug 4, 2015
Added exporting autoscaling metrics in Heapster config
|
@alex-mohr good point. Will change the version to make sure #12098 can be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11748
@vishh