Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #121008: Make a certain ipv4-vs-ipv6 config error non-fatal, for #121029

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Automated cherry pick of #121008: Make a certain ipv4-vs-ipv6 config error non-fatal, for #121029

merged 1 commit into from
Oct 9, 2023

Conversation

danwinship
Copy link
Contributor

@danwinship danwinship commented Oct 6, 2023 •
edited by liggitt
Loading

Cherry pick of #121008 on release-1.28.

#121008: Make a certain ipv4-vs-ipv6 config error non-fatal, for

For details on the cherry pick process, see the cherry pick requests page.

Fixed a 1.28 regression in kube-proxy where it might refuse to start if given single-stack IPv6 configuration options on a node that has both IPv4 and IPv6 IPs.

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 6, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and khenidak October 6, 2023 15:18
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 6, 2023
@danwinship
Copy link
Contributor Author

/priority important-soon
/kind bug
/king regression

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 6, 2023
@danwinship
Copy link
Contributor Author

/kind regression

@k8s-ci-robot k8s-ci-robot added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Oct 6, 2023
@CecileRobertMichon
Copy link
Member

Confirmed this fixed the regression at k/k head

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e0d0ede72fd0e2ee43d5e6f842c2ca2acfd5a40

@danwinship
Copy link
Contributor Author

/retest-required

@aojea
Copy link
Member

aojea commented Oct 6, 2023

ping @kubernetes/release-managers

@palnabarun
Copy link
Member

/hold
for the priority to be updated (ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1696684484950329?thread_ts=1696670020.399389&cid=C2C40FMNF). Please remove the hold when updated.

Meanwhile, approving the cherry pick to unblock CI.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2023
@palnabarun palnabarun added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Oct 7, 2023
@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 7, 2023
@danwinship
Copy link
Contributor Author

/priority critical-urgent
since it's breaking some CI apparently
/hold cancel

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 9, 2023
@CecileRobertMichon
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 669efe4 into kubernetes:release-1.28 Oct 9, 2023
@danwinship danwinship deleted the automated-cherry-pick-of-#121008-origin-release-1.28 branch October 10, 2023 14:27
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
5 participants
@danwinship @k8s-ci-robot @CecileRobertMichon @aojea @palnabarun