-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #118601: priority & fairness: support dynamic max seats #119574
Automated cherry pick of #118601: priority & fairness: support dynamic max seats #119574
Conversation
…ax seats Max seats from prioriy & fairness work estimator is now min(0.15 x nominalCL, nominalCL/handSize) 'Max seats' calculated by work estimator is currently hard coded to 10. When using lower values for --max-requests-inflight, a single LIST request taking up 10 seats could end up using all if not most seats in the priority level. This change updates the default work estimator config such that 'max seats' is at most 10% of the maximum concurrency limit for a priority level, with an upper limit of 10. This ensures seats taken from LIST request is proportional to the total available seats. Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
7b299f1
to
4c5ea17
Compare
/assign @wojtek-t @MikeSpreitzer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 06ece054f83217766fd2bda08646ff0ff551bef7
|
/lgtm /priority important-soon @kubernetes/release-managers for cherrypick approval |
/triage accepted |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, MikeSpreitzer, saschagrunert, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #118601 on release-1.25.
#118601: priority & fairness: support dynamically configuring work
For details on the cherry pick process, see the cherry pick requests page.