Match both old and new kubectl version for a while in e2e #119251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/failing-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
ardaguclu
reviewed
Jul 12, 2023
| @@ -1676,7 +1676,12 @@ metadata: | |||
| // we expect following values for: Major -> digit, Minor -> numeric followed by an optional '+', GitCommit -> alphanumeric | |||
| requiredItems := []string{"Client Version: ", "Server Version: "} | |||
| for _, item := range requiredItems { | |||
| if matched, _ := regexp.MatchString(item+`v\d\.\d+\.[\d\w\-\.\+]+`, versionString); !matched { | |||
| // prior to 1.28 we printed long version information | |||
| oldMatched, _ := regexp.MatchString(item+`version.Info\{Major:"\d", Minor:"\d+\+?", GitVersion:"v\d\.\d+\.[\d\w\-\.\+]+", GitCommit:"[0-9a-f]+"`, versionString) | |||
There was a problem hiding this comment.
We can not run kubectl version -ojson because kubectl is still old and will fail?.
There was a problem hiding this comment.
we could, but I don't want that, I want the bare kubectl version output here, only
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 13b2c05268e9de4447469a8a406341d4ba55d03c
|
|
/test pull-kubernetes-conformance-kind-ga-only-parallel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
/kind flake
/sig cli
/sig testing
What this PR does / why we need it:
In #116720 I dropped the deprecated long version, but our release informing jobs are using an older version of kubectl which still prints the long version.
Based on that, given our compatibility guarantees I'll match either the new or the old version until 1.30.
Which issue(s) this PR fixes:
Fixes #119230
Special notes for your reviewer:
/assign @ardaguclu
Does this PR introduce a user-facing change?