update meteor example according to config best practices. #11399
+8
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCE e2e build/test passed for commit 3cc0f95e251a481bd4955ce8e5d97767e9422785. |
| @@ -14,7 +14,6 @@ | |||
| "selector": { | |||
| "name": "meteor" | |||
| }, | |||
| "sessionAffinity": "ClientIP", | |||
| "type": "LoadBalancer" | |||
There was a problem hiding this comment.
why do you remove the loadbalancer?
There was a problem hiding this comment.
accident, I thought it was a default for a second. I have readded it.
caesarxuchao
added
the
lgtm
|
LGTM. Thanks! |
|
GCE e2e build/test passed for commit 392d4e0708f0a4a35dbfe910415cb59ff219cc0c. |
mikedanese
force-pushed
the
fixup-meteor
branch
2 times, most recently
from
f6b855b to
f981857
Compare
|
LGTM, thanks! |
|
GCE e2e build/test failed for commit f6b855b231918518e67e214b5fa1445a5e7652cd. |
|
#11460 will fix the shippable failure here, but it's not merged yet |
|
GCE e2e build/test passed for commit f981857bf3efccbb7404b5796ebdc440c505e322. |
|
GCE e2e build/test passed for commit 1133b62. |
davidopp
added a commit
that referenced
this pull request
Jul 17, 2015
update meteor example according to config best practices.
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #11361