Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup kubectl walktrough example #11396

Merged
merged 1 commit into from
Jul 17, 2015
Merged

fixup kubectl walktrough example #11396

merged 1 commit into from
Jul 17, 2015

Conversation

mikedanese
Copy link
Member

@k8s-bot
Copy link

k8s-bot commented Jul 16, 2015

GCE e2e build/test failed for commit 42d4035a5ae7679325026767f3dd223f778c8666.

bgrant0607
bgrant0607 reviewed Jul 16, 2015
View reviewed changes
docs/user-guide/prereqs.md

By default, kubectl configuration lives at `~/.kube/config`.

If your cluster was deployed by other means (e.g. a [getting started guide](../getting-started-guides/README.md)) your kubectl client will typically be configured during that process. I for some reason your kubectl client is not yet configured, checkout [kubeconfig-file.md](kubeconfig-file.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I for some reason" should be "If for some reason"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/checkout/check out/

@bgrant0607 bgrant0607 added this to the v1.0 milestone Jul 16, 2015
@bgrant0607 bgrant0607 added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 16, 2015
bgrant0607
bgrant0607 reviewed Jul 17, 2015
View reviewed changes
docs/user-guide/walkthrough/k8s201.md
- [What's Next?](#whats-next)
**Table of Contents**
<!-- BEGIN MUNGE: GENERATED_TOC -->
- [Kubernetes 201 - Labels, Replication Controllers, Services and Health Checking](#kubernetes-201---labels,-replication-controllers,-services-and-health-checking)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commas don't seem to work either, but not a big deal since this is the top of the doc.

Actual anchor is:
#kubernetes-201---labels-replication-controllers-services-and-health-checking

We should strip commas @janetkuo

@bgrant0607
Copy link
Member

LGTM
doc checks passed
ok to merge

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Jul 17, 2015
This was referenced Jul 17, 2015
Closed
Closed
@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit 8083a675386ebcb41367b9ea35ea492f94c9acea.

@k8s-bot
Copy link

k8s-bot commented Jul 17, 2015

GCE e2e build/test passed for commit a654318.

ArtfulCoder added a commit that referenced this pull request Jul 17, 2015
@ArtfulCoder
Merge pull request #11396 from mikedanese/fixups
5124a15 
fixup kubectl walktrough example
@ArtfulCoder ArtfulCoder merged commit 5124a15 into kubernetes:master Jul 17, 2015
@mikedanese mikedanese deleted the fixups branch July 17, 2015 01:37
@mikedanese mikedanese mentioned this pull request Jul 17, 2015
Merged
@karlkfi
Copy link
Contributor

karlkfi commented Jul 17, 2015

look like it's too late for this one, but I already made my case to another reviewer: I really dislike having $ before shell commands, because it makes it hard to copy/paste them. This is especially true of multi-line command blocks. The time I believe having a $ is logical is when showing both input and stdout/stderr in the same block.

@bgrant0607
Copy link
Member

It's for consistency with other docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mikedanese @k8s-bot @bgrant0607 @karlkfi @ArtfulCoder @googlebot