Remove PodSecurityPolicy admission plugin #109798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/XXL
liggitt
commented
May 4, 2022
| psputil "k8s.io/kubernetes/pkg/security/podsecuritypolicy/util" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
these were hoisted from k8s.io/kubernetes/pkg/security/podsecuritypolicy/seccomp to allow deleting that package
liggitt
commented
May 4, 2022
| @@ -332,6 +339,44 @@ func validatePodSecurityPolicyVolumes(fldPath *field.Path, volumes []policy.FSTy | |||
| return allErrs | |||
| } | |||
|
|
|||
| // getAllFSTypesAsSet returns all actual volume types, regardless | |||
| // of feature gates. The special policy.All pseudo type is not included. | |||
| func getAllFSTypesAsSet() sets.String { | |||
There was a problem hiding this comment.
this was hoisted from k8s.io/kubernetes/pkg/security/podsecuritypolicy/util to allow deleting that package
liggitt
commented
May 4, 2022
| type SysctlsStrategy interface { | ||
| // Validate ensures that the specified values fall within the range of the strategy. | ||
| Validate(pod *api.Pod) field.ErrorList | ||
| // SafeSysctlAllowlist returns the allowlist of safe sysctls and safe sysctl patterns (ending in *). |
There was a problem hiding this comment.
this was hoisted from k8s.io/kubernetes/pkg/security/podsecuritypolicy/sysctl to allow deleting that package
k8s-ci-robot
added
area/apiserver
area/e2e-test-framework
|
/triage accepted |
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
priority/important-soon
enj
approved these changes
May 4, 2022
k8s-ci-robot
added
area/provider/gcp
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
sig/cloud-provider
|
heh, yeah, test-cmd got me in the 1.25 removals. /lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
sftim
reviewed
May 5, 2022
Comment on lines
+42
to
+44
| seccompDefaultProfileAnnotationKey = "seccomp.security.alpha.kubernetes.io/defaultProfileName" | ||
| // AllowedProfilesAnnotationKey specifies the allowed seccomp profiles. | ||
| seccompAllowedProfilesAnnotationKey = "seccomp.security.alpha.kubernetes.io/allowedProfileNames" |
There was a problem hiding this comment.
These are being removed too, right? As part of #109819
There was a problem hiding this comment.
This API code is staying unchanged for 1.25 and will be removed in 1.26. The other PR is on my radar to review as well
7 tasks
This was referenced Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind deprecation
What this PR does / why we need it:
Removes the PodSecurityPolicy admission plugin
Which issue(s) this PR fixes:
xref kubernetes/enhancements#5
Does this PR introduce a user-facing change?
/sig auth security
/cc @deads2k @enj @ritazh @mikedanese