Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audit annotations and log prefixes to deprecated cert warnings #109107

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Add audit annotations and log prefixes to deprecated cert warnings #109107

merged 1 commit into from
Mar 30, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 29, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds audit annotations when invalid certificates are encountered

Follow up to #109024

Which issue(s) this PR fixes:

Fixes #108940

Does this PR introduce a user-facing change?

NONE

(will update release note in #108940)

/assign @tallclair @stlaz

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

@liggitt: GitHub didn't allow me to assign the following users: stlaz.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds audit annotations when invalid certificates are encountered

Follow up to #109024

Which issue(s) this PR fixes:

Fixes #108940

Does this PR introduce a user-facing change?

NONE

(will update release note in #108940)

/assign @tallclair @stlaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@liggitt liggitt force-pushed the deprecated-cert-audit branch from d3101be to 042675c Compare March 29, 2022 14:43
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 29, 2022
@liggitt liggitt force-pushed the deprecated-cert-audit branch from 042675c to f1dd9a6 Compare March 29, 2022 14:45
@liggitt liggitt added this to the v1.24 milestone Mar 29, 2022
@liggitt liggitt mentioned this pull request Mar 29, 2022
Closed
4 tasks
@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 29, 2022
tallclair
tallclair reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@tallclair tallclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@liggitt
Copy link
Member Author

liggitt commented Mar 29, 2022

unit flake: #105589

/retest

@cici37
Copy link
Contributor

cici37 commented Mar 29, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 29, 2022
@liggitt
Copy link
Member Author

liggitt commented Mar 29, 2022

#109082 flake
/retest

@k8s-ci-robot k8s-ci-robot merged commit 7fba4f7 into kubernetes:master Mar 30, 2022
@liggitt liggitt mentioned this pull request Mar 30, 2022
Merged
@liggitt liggitt deleted the deprecated-cert-audit branch May 5, 2022 15:00
@MadhavJivrajani MadhavJivrajani mentioned this pull request Jun 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

go1.18: Add metrics for SHA-1 certificates that will be rejected by go1.18
4 participants
@liggitt @k8s-ci-robot @cici37 @tallclair