Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change "get minions" to "get nodes" in docs #10843

Merged
merged 1 commit into from
Jul 13, 2015
Merged

change "get minions" to "get nodes" in docs #10843

merged 1 commit into from
Jul 13, 2015
+40 −40

Conversation

jiangyaoguo
Copy link
Contributor

Now the "get minions" has been changed to "get nodes". There're still some where unchanged in docs.

@k8s-bot
Copy link

k8s-bot commented Jul 7, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@nikhiljindal
Copy link
Contributor

@k8s-bot ok to test

@nikhiljindal
Copy link
Contributor

This change LGTM, but while we are at it, I will recommend updating all references to minions in that doc to say nodes.

@nikhiljindal
Copy link
Contributor

cc @bgrant0607

@k8s-bot
Copy link

k8s-bot commented Jul 7, 2015

GCE e2e build/test passed for commit 18bd88ee8c9675ad8d8afb38e93520f802b1aa33.

@nikhiljindal nikhiljindal mentioned this pull request Jul 8, 2015
Merged
@jiangyaoguo
Copy link
Contributor Author

@nikhiljindal @janetkuo Since JanetKuo has done the works in vagrant.md, I 'll change the other docs.

@jiangyaoguo jiangyaoguo force-pushed the change-get-minions-in-docs branch from 18bd88e to a9f3a3b Compare July 8, 2015 08:04
@k8s-bot
Copy link

k8s-bot commented Jul 8, 2015

GCE e2e build/test passed for commit a9f3a3bb7faafcdf728a62f10224b38f524d50a5.

@jiangyaoguo
Copy link
Contributor Author

@nikhiljindal

@nikhiljindal
Copy link
Contributor

Sorry needs rebase

nikhiljindal
nikhiljindal reviewed Jul 9, 2015
View reviewed changes
docs/getting-started-guides/fedora/fedora_ansible_config.md
@@ -110,7 +110,7 @@ The ansible scripts are quite hacky configuring the network, you can see the [RE

**Configure the ip addresses which should be used to run pods on each machine**

The IP address pool used to assign addresses to pods for each minion is the `kube_ip_addr`= option. Choose a /24 to use for each minion and add that to you inventory file.
The IP address pool used to assign addresses to pods for each node is the `kube_ip_addr`= option. Choose a /24 to use for each node and add that to you inventory file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add that to you inventory -> add that to your inventory

@nikhiljindal
Copy link
Contributor

changes LGTM

@jiangyaoguo jiangyaoguo force-pushed the change-get-minions-in-docs branch from a9f3a3b to 102c56d Compare July 10, 2015 02:41
@jiangyaoguo
Copy link
Contributor Author

@nikhiljindal Thanks a lot for your review. I have rebased it and made a change.

@k8s-bot
Copy link

k8s-bot commented Jul 10, 2015

GCE e2e build/test passed for commit 102c56d.

@jiangyaoguo jiangyaoguo mentioned this pull request Jul 10, 2015
Closed
@nikhiljindal
Copy link
Contributor

Shippable had timed out. Restarted it

@jiangyaoguo
Copy link
Contributor Author

@nikhiljindal How can I restart shippable check manually?

@nikhiljindal
Copy link
Contributor

I did it.

For next time, you can click on "Details" next to shippable, which will take you the build for this PR on app.shippable.com.
There you will see a refresh like button, which will say "Re-run Build" when you hover over it. The button is towards top-right on that page.

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2015
@nikhiljindal nikhiljindal mentioned this pull request Jul 13, 2015
Merged
@nikhiljindal nikhiljindal added this to the v1.0 milestone Jul 13, 2015
@bgrant0607
Copy link
Member

Thanks much for the change. @thockin please resolve overlap with #11130

@bgrant0607 bgrant0607 added kind/documentation Categorizes issue or PR as related to documentation. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 13, 2015
thockin added a commit that referenced this pull request Jul 13, 2015
@thockin
Merge pull request #10843 from jiangyaoguo/change-get-minions-in-docs
8bb5c50 
change "get minions" to "get nodes"  in docs
@thockin thockin merged commit 8bb5c50 into kubernetes:master Jul 13, 2015
@jiangyaoguo jiangyaoguo deleted the change-get-minions-in-docs branch September 12, 2015 01:40
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
@thockin
Merge pull request kubernetes#10843 from jiangyaoguo/change-get-minio…
8eebde7 
…ns-in-docs

change "get minions" to "get nodes"  in docs
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
@thockin
Merge pull request kubernetes#10843 from jiangyaoguo/change-get-minio…
087b173 
…ns-in-docs

change "get minions" to "get nodes"  in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jiangyaoguo @k8s-bot @nikhiljindal @bgrant0607 @googlebot @thockin