storage e2e: replace mock driver, update images #106791
Conversation
This is a first step towards removing the mock CSI driver completely from e2e testing in favor of hostpath plugin. With the recent hostpath plugin changes(PR kubernetes#260, kubernetes#269), it supports all the features supported by the mock csi driver. Using hostpath-plugin for testing also covers CSI persistent feature usecases.
This is an automatic update of the testing manifests that mirrors the v1.7.3 release. All of these changes were created with test/e2e/testing-manifests/storage-csi$ ./update-hostpath.sh v1.7.3
The same change was already done for csi-driver-host-path master, but not released yet because csi-snapshotter v5.0.0 itself was not ready yet. We need this update in k/k because some canary jobs already use the new snapshotter sidecar which causes permission issues.
k8s-ci-robot
added
release-note-none
|
@pohly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
These changes were created automatically with the updated update-hostpath.sh script.
pohly
force-pushed
the
replace-mock-driver
branch
from
8cf86c7 to
a39b387
Compare
| @@ -15,7 +15,7 @@ spec: | |||
| serviceAccountName: csi-mock | |||
| containers: | |||
| - name: csi-snapshotter | |||
| image: k8s.gcr.io/sig-storage/csi-snapshotter:v4.0.0 | |||
| image: k8s.gcr.io/sig-storage/csi-snapshotter:v4.2.1 | |||
There was a problem hiding this comment.
Should this be using the v5.0.0-rc1 image?
There was a problem hiding this comment.
I don't think so. The goal is to be as close as possible to the released csi-driver-host-path deployment..
The canary jobs cover the upcoming releases.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.23 |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind cleanup
/kind failing-test
What this PR does / why we need it:
https://testgrid.kubernetes.io/sig-storage-csi-ci#canary-on-master is failing because the new snapshotter image gets patched in via https://github.com/kubernetes-csi/csi-release-tools/blob/a6a1a7979bf3ebc2bb10d0e33dd11ab281d6d39e/prow.sh#L911-L932 while the deployed RBAC rules are for the stable snapshotter release and therefore don't have the "patch" verb enabled.
The csi mock driver has been obsoleted and should not have been used anymore. That #101672 hadn't been merged was an oversight.
Besides that it is good practice to stay up-to-date, so all images get updated where possible.
Does this PR introduce a user-facing change?
/cc @xing-yang