Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: Document --for's Unicode case-folding condition-value comparison #104671

Merged
merged 1 commit into from
Jan 6, 2022
Merged

kubectl: Document --for's Unicode case-folding condition-value comparison #104671

merged 1 commit into from
Jan 6, 2022

Conversation

wking
Copy link
Contributor

@wking wking commented Aug 31, 2021 •
edited
Loading

When the wait command was added in 7679464 (#64034), this comparison was via ToLower. It moved to use Unicode case folding in f4940cf (#87403).

It's possible that saying "string-insensitive matching" is sufficient. Seems like Go is using SimpleFold to implement EqualFold, and that means full case-fold situations like ß ⇒ ss aren't implemented. In some brief poking around, I haven't found a situation where EqualFold(a,b) diverges from ToLower(a) == ToLower(b).

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

@wking: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @wking. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 31, 2021
@wking wking force-pushed the doc-wait-for-condition-case-folding branch from d587dc8 to 44a7975 Compare August 31, 2021 03:10
2uasimojo
2uasimojo reviewed Aug 31, 2021
View reviewed changes
Copy link

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good add, thanks Trevor.

staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go Outdated Show resolved Hide resolved
staging/src/k8s.io/kubectl/pkg/cmd/wait/wait.go Outdated Show resolved Hide resolved
@pacoxu
Copy link
Member

pacoxu commented Nov 8, 2021

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 8, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2021
@wking wking force-pushed the doc-wait-for-condition-case-folding branch 2 times, most recently from 8a12979 to b436cae Compare November 16, 2021 22:21
2uasimojo
2uasimojo reviewed Nov 16, 2021
View reviewed changes
Copy link

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@2uasimojo: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
kubectl: Document --for's Unicode case-folding condition-value compar…
f69d523 
…ison

When the wait command was added in 7679464 (add wait, 2018-05-18, kubernetes#64034),
this comparison was via ToLower.  It moved to use Unicode case folding
[1,2] in f4940cf (Staticcheck:
vendor/k8s.io/kubectl/pkg/scale|describe/versioned|cmd/top|cmd/util/editor|cmd/top,
2020-01-21, kubernetes#87403).

[1]: https://pkg.go.dev/strings#EqualFold
[2]: http://www.unicode.org/reports/tr30/tr30-1.html
@wking
Copy link
Contributor Author

wking commented Nov 17, 2021

Rebased around #105776 with b436cae85a9 -> f69d523

@wking wking force-pushed the doc-wait-for-condition-case-folding branch from b436cae to f69d523 Compare November 17, 2021 21:12
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021
2uasimojo
2uasimojo reviewed Nov 17, 2021
View reviewed changes
Copy link

@2uasimojo 2uasimojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good. I reinstate my impotent

/lgtm

@k8s-ci-robot
Copy link
Contributor

@2uasimojo: changing LGTM is restricted to collaborators

In response to this:

Still good. I reinstate my impotent

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Jan 4, 2022

/ok-to-test
/assign @seans3 @eddiezane

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2022
@eddiezane
Copy link
Member

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddiezane, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit d7fab66 into kubernetes:master Jan 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2uasimojo 2uasimojo 2uasimojo left review comments

@dixudx dixudx Awaiting requested review from dixudx

@eddiezane eddiezane Awaiting requested review from eddiezane

Assignees

@eddiezane eddiezane

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
7 participants
@wking @k8s-ci-robot @pacoxu @dims @eddiezane @2uasimojo @seans3