Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update corefile-migration to v1.0.12. #102830

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Update corefile-migration to v1.0.12. #102830

merged 1 commit into from
Jun 14, 2021

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jun 13, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The coredns/corefile-migration project switched to a fork of
coredns/caddy to remove dependencies it doesn't actually need. Picking
up this update here in k/k results in a significantly smaller go.mod.

Signed-off-by: Dan Lorenc dlorenc@google.com

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 13, 2021
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 13, 2021
Update corefile-migration to v1.0.12.
8748f31 
The coredns/corefile-migration project switched to a fork of
coredns/caddy to remove dependencies it doesn't actually need. Picking
up this update here in k/k results in a significantly smaller go.mod.

Signed-off-by: Dan Lorenc <dlorenc@google.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 13, 2021
rajansandeep
rajansandeep reviewed Jun 13, 2021
View reviewed changes
Copy link
Contributor

@rajansandeep rajansandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe #102466 is updating the migration library to 1.0.12

@dlorenc
Copy link
Contributor Author

dlorenc commented Jun 13, 2021

Ah thanks! Missed it in my search because it was a draft.

@dims
Copy link
Member

dims commented Jun 13, 2021

/sig cluster-lifecycle
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 13, 2021
@dims
Copy link
Member

dims commented Jun 13, 2021

/assign @neolit123 @liggitt

Lubomir, does this look good? since kubeadm is the only one using this package:
https://cs.k8s.io/?q=coredns%2Fcorefile-migration&i=nope&files=.*%5C.go&excludeFiles=&repos=kubernetes/kubernetes

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2021
@dims
Copy link
Member

dims commented Jun 13, 2021

@liggitt looks like we are dropping stuff nicely!

2c2
< 	"totalDependencies": 380,
---
> 	"totalDependencies": 364,
4c4
< 	"transitiveDependencies": 254
---
> 	"transitiveDependencies": 238

@liggitt
Copy link
Member

liggitt commented Jun 14, 2021

@liggitt looks like we are dropping stuff nicely!

fantastic

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, dlorenc, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 261b32d into kubernetes:master Jun 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 14, 2021
@neolit123
Copy link
Member

neolit123 commented Jun 14, 2021 via email •
edited
Loading

@dlorenc dlorenc deleted the caddy branch June 14, 2021 14:09
@neolit123 neolit123 mentioned this pull request Jun 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajansandeep rajansandeep rajansandeep left review comments

@liggitt liggitt Awaiting requested review from liggitt

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dims dims

@neolit123 neolit123

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@dlorenc @dims @liggitt @k8s-ci-robot @neolit123 @rajansandeep