Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adjust summary test for cgroup v2 #102726

Merged
merged 1 commit into from
Jun 10, 2021
Merged

test: adjust summary test for cgroup v2 #102726

merged 1 commit into from
Jun 10, 2021

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Jun 9, 2021 •
edited
Loading

on cgroup v2 the reported metric is recursive for the entire cgroup
and it includes all the sub cgroups.

Adjust the test accordingly.

Closes: #99230

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

adjust the expected value to what we get on cgroup v2

Which issue(s) this PR fixes:

Fixes #99230

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/issues/2254

@giuseppe
test: adjust summary test for cgroup v2
c98306a 
on cgroup v2 the reported metric is recursive for the entire and it
includes all the sub cgroups.

Adjust the test accordingly.

Closes: kubernetes#99230

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 9, 2021
@giuseppe
Copy link
Member Author

giuseppe commented Jun 9, 2021

/sig node

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from bsdnet and resouer June 9, 2021 12:08
@giuseppe giuseppe mentioned this pull request Jun 9, 2021
Closed
@dashpole
Copy link
Contributor

dashpole commented Jun 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@giuseppe
Copy link
Member Author

giuseppe commented Jun 9, 2021

/test pull-kubernetes-node-crio-cgrpv2-e2e

@giuseppe
Copy link
Member Author

giuseppe commented Jun 9, 2021

looks like a flake:

/test pull-kubernetes-node-crio-cgrpv2-e2e

@giuseppe
Copy link
Member Author

giuseppe commented Jun 9, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@giuseppe
Copy link
Member Author

giuseppe commented Jun 9, 2021

all tests are green, including pull-kubernetes-node-crio-cgrpv2-e2e

@harche FYI

@harche
Copy link
Contributor

harche commented Jun 9, 2021

@giuseppe Awesome!

/cc @mrunalp @rphillips

@k8s-ci-robot k8s-ci-robot requested review from mrunalp and rphillips June 9, 2021 15:49
@SergeyKanzhelev
Copy link
Member

/cc @Dragoncell
/priority important-soon
/triage accepted

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: GitHub didn't allow me to request PR reviews from the following users: Dragoncell.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Dragoncell
/priority important-soon
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 10, 2021
@giuseppe
Copy link
Member Author

/cc @derekwaynecarr @ehashman

@kolyshkin kolyshkin mentioned this pull request Jun 10, 2021
Merged
ehashman
ehashman reviewed Jun 10, 2021
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit f32dd21 into kubernetes:master Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 10, 2021
@bobbypage bobbypage mentioned this pull request Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehashman ehashman ehashman left review comments

@mrunalp mrunalp mrunalp approved these changes

@bsdnet bsdnet Awaiting requested review from bsdnet

@resouer resouer Awaiting requested review from resouer

@rphillips rphillips Awaiting requested review from rphillips

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dashpole dashpole

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

Failing kubelet /stats/summary API and ResourceMetricsAPI tests on cgroup v2
7 participants
@giuseppe @dashpole @harche @SergeyKanzhelev @k8s-ci-robot @mrunalp @ehashman