Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Cleanup portforward streams after their usage" [1.19] #102588

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Revert "Cleanup portforward streams after their usage" [1.19] #102588

merged 1 commit into from
Jun 4, 2021
+4 −85

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 4, 2021 •
edited by liggitt
Loading

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

This reverts commit a1ee076.

A regression has been introduced with this patch. The strategy is to apply the fix on master and revert on the release branches.

Which issue(s) this PR fixes:

Refers to #102489

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed a regression in 1.19.11 that can make kubelet runtime panic for timed-out portforward streams.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@saschagrunert
Revert "Cleanup portforward streams after their usage"
21900bc 
This reverts commit a1ee076.

A regression has been introduced with this patch. The strategy is to
apply the fix on master and revert on the release branches.
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 4, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 4, 2021
@saschagrunert saschagrunert changed the title Revert "Cleanup portforward streams after their usage" Revert "Cleanup portforward streams after their usage" [1.19] Jun 4, 2021
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 4, 2021
@saschagrunert saschagrunert mentioned this pull request Jun 4, 2021
Merged
@lavalamp
Copy link
Member

lavalamp commented Jun 4, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021
@puerco
Copy link
Member

puerco commented Jun 4, 2021

/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 4, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit f1bbe35 into kubernetes:release-1.19 Jun 4, 2021
@saschagrunert saschagrunert deleted the release-1.19 branch June 4, 2021 17:02
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 8, 2021
@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@lavalamp lavalamp

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@saschagrunert @lavalamp @k8s-ci-robot @puerco @fedebongio @liggitt