Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pkg/proxy/ipvs/ipset.go logs to structured logging #102031

Closed
wants to merge 4 commits into from
Closed

Migrate pkg/proxy/ipvs/ipset.go logs to structured logging #102031

wants to merge 4 commits into from

Conversation

Nick-Triller
Copy link
Contributor

@Nick-Triller Nick-Triller commented May 15, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @Nick-Triller. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/ipvs sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nick-Triller
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shubheksha
Copy link
Contributor

/wg structured-logging
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 27, 2021
shubheksha
shubheksha suggested changes May 27, 2021
View reviewed changes
pkg/proxy/ipvs/ipset.go Outdated Show resolved Hide resolved
pkg/proxy/ipvs/ipset.go Outdated Show resolved Hide resolved
pkg/proxy/ipvs/ipset.go Outdated Show resolved Hide resolved
@Nick-Triller Nick-Triller force-pushed the pkg_proxy_ipvs_ipset_structued_logging branch from 94410cc to 3b99017 Compare May 28, 2021 09:57
Nick-Triller and others added 4 commits May 28, 2021 11:58
@Nick-Triller
Migrate pkg/proxy/ipvs/ipset.go logs to structured logging
02df552
@Nick-Triller @shubheksha
Update pkg/proxy/ipvs/ipset.go
beb0d35 
Apply suggestion

Co-authored-by: Shubheksha <shubheksha@users.noreply.github.com>
@Nick-Triller @shubheksha
Update pkg/proxy/ipvs/ipset.go
9be1a5d 
Apply suggestion

Co-authored-by: Shubheksha <shubheksha@users.noreply.github.com>
@Nick-Triller @shubheksha
Update pkg/proxy/ipvs/ipset.go
081106e 
Apply suggestion

Co-authored-by: Shubheksha <shubheksha@users.noreply.github.com>
@Nick-Triller Nick-Triller force-pushed the pkg_proxy_ipvs_ipset_structued_logging branch from 3b99017 to 081106e Compare May 28, 2021 09:58
@Nick-Triller
Copy link
Contributor Author

Hi @shubheksha, thanks for your suggestions. I applied all of them and rebased on master.

@yangjunmyfm192085
Copy link
Contributor

/wg structured-logging

@reylejano reylejano mentioned this pull request Jun 23, 2021
Open
39 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2021
@pacoxu pacoxu mentioned this pull request Sep 13, 2021
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 1, 2021
@Nick-Triller
Copy link
Contributor Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 1, 2021
@shivanshuraj1333
Copy link
Contributor

Closing as some of the logs are not properly migrated and #104932 (comment) got merged which covers migration of this file.
/close

@k8s-ci-robot
Copy link
Contributor

@Nick-Triller: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2021
@k8s-ci-robot
Copy link
Contributor

@shivanshu1333: Closed this PR.

In response to this:

Closing as some of the logs are not properly migrated and #104932 (comment) got merged which covers migration of this file.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Nick-Triller
Copy link
Contributor Author

Hi @shivanshu1333, I would like to take this as an opportunity to learn. Which logs were not properly migrated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubheksha shubheksha shubheksha requested changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees
No one assigned
Labels
area/ipvs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Nick-Triller @k8s-ci-robot @shubheksha @yangjunmyfm192085 @k8s-triage-robot @shivanshuraj1333