Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"--read-only-port" field description is confusing. #94550

Closed
warmchang opened this issue Sep 5, 2020 · 3 comments
Closed

"--read-only-port" field description is confusing. #94550

warmchang opened this issue Sep 5, 2020 · 3 comments
Assignees
@warmchang
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@warmchang
Copy link
Contributor

What happened:

As "kubelet --help" said, the default --read-only-port is 10255, but actually the default value is 0 (disabled):

 root@william  ~/go/src/k8s.io/kubernetes  _output/local/bin/linux/amd64/kubelet --version                                                      ✔  ⚡  7961  15:42:13
Kubernetes v1.19.0
 root@william  ~/go/src/k8s.io/kubernetes  _output/local/bin/linux/amd64/kubelet --help | grep read-only                                        ✔  ⚡  7962  15:42:18
      --read-only-port int32                                     The read-only port for the Kubelet to serve on with no authentication/authorization (set to 0 to disable) (default 10255) (DEPRECATED: This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.)
 root@william  ~/go/src/k8s.io/kubernetes                                                                                                       ✔  ⚡  7963  15:42:25

kubernetes/staging/src/k8s.io/kubelet/config/v1beta1/types.go

Line 146 in 1f708f6

// Default: 0 (disabled)

What you expected to happen:

Keep the context consistent, as a quick fix, we can set KubeletReadOnlyPort = 0.

kubernetes/pkg/cluster/ports/ports.go

Line 39 in 1f708f6

KubeletReadOnlyPort = 10255

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): v1.19.0
  • Cloud provider or hardware configuration: N/A
  • OS (e.g: cat /etc/os-release): Fedora 32 (Cloud Edition)
  • Kernel (e.g. uname -a): 5.8.4-200.fc32.x86_64
  • Install tools: N/A
  • Network plugin and version (if this is a network-related bug): N/A
  • Others: N/A
@warmchang warmchang added the kind/bug Categorizes issue or PR as related to a bug. label Sep 5, 2020
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 5, 2020
@warmchang
Copy link
Contributor Author

/sig node
/assign @warmchang

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2020
@warmchang warmchang mentioned this issue Sep 5, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Sep 6, 2020

The CLI documentation is saying to set it to 0 to disable, and that the default is still 10255.

@liggitt liggitt removed the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2020
@liggitt
Copy link
Member

liggitt commented Sep 8, 2020

The CLI help is accurate... when starting the kubelet with CLI flags (not from a config file), the default is 10255. See #94551 (comment)

@liggitt liggitt closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warmchang warmchang

Labels
sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the default KubeletReadOnlyPort value to 0 (disabled)
3 participants
@liggitt @warmchang @k8s-ci-robot