-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove alpha support for Hyper-v on Docker for Windows #94490
Comments
/remove-kind bug |
I can try to contribute to solve this issue /assign |
Do we need to discuss whether we confirm that we need to remove this feature in the kubernetes code? If it is removed, it will not support running hyper-v-based windows container through docker. |
We can add it to the agenda for sig-windows next week to confirm. There is no path forward for hyper-v containers with docker so it should be ok to remove via standard depreciation mechanisms. We have been working to get hyper-v working via containerd (still work in progress) and have tests passes: https://testgrid.k8s.io/sig-windows-containerd#aks-engine-azure-windows-master-containerd-hyperv |
@neolit123 What is the process for announcing and removing an experimental annotation? I read through https://kubernetes.io/docs/reference/using-api/deprecation-policy/ but it mostly refers to api changes. |
I submitted a simple pr for this issue, we can follow up the results of the discussion next week for further operations |
I also read this document and found that there is a short description related to this issue https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-a-feature-or-behavior I am confused about this point. It seems that the feature of hyper-v can be removed (because it has been in alpha for a long time, experimental feature), I don’t know if my understanding is correct. |
alpha feature gates can be removed without a deprecation period in release N+1 if added in release N - i.e. it could have been removed in 1.11 as per the minimum policy. my recommendation would be to announce this as deprecated in 1.20 and remove in 1.21. ideally sig-windows should decide on the timing. |
+1. Could we add a warning log and an announcement in v1.20 and then remove it in v1.21? |
If sig-windows has the latest discussion results, please let me know and I can try to follow up this issue |
We discussed this at sig-windows and agree should be a log warning for depreciation in 1.20 and remove support in v1.21. @wawa0210 can you update the PR to log the warning and add the appropriate release note? |
This should stay open as a tracking issue untill the feature is removed in 1.21 |
/reopen |
@jsturtevant: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jsturtevant: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
What happened:
Hyper-v support was added as an experimental feature via annotations for docker. Hyper-v support is now focused on Containerd because of better support of HCSv2 in Containerd (for example allows for multiple containers in a pod in hyper-v).
There is still annotation support that should be removed in all the various locations:
kubernetes/pkg/kubelet/apis/well_known_annotations_windows.go
Line 36 in 9d9d305
What you expected to happen:
hyper-v support for docker will not go past alpha so the annotations should be depreciated following the guidelines at https://kubernetes.io/docs/reference/using-api/deprecation-policy/
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl version
):cat /etc/os-release
): Windowsuname -a
):/sig windows
The text was updated successfully, but these errors were encountered: