Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node status test should mock out ip lookup #8549

Closed
bprashanth opened this issue May 20, 2015 · 3 comments · Fixed by #8579
Closed

Node status test should mock out ip lookup #8549

bprashanth opened this issue May 20, 2015 · 3 comments · Fixed by #8579
Assignees
@roberthbailey
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@bprashanth
Copy link
Contributor

Looks like some kubelet unit tests perform a lookupIp which ends up depending on the health of the local resolver. Specifically @timothysc has this failing:
http://fpaste.org/223604/14320862/

Which leads to the test in: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubelet/kubelet_test.go#L3317
And we recently swapped out the node names from testnode to 127.0.0.1, so probably the culprit?

@roberthbailey
@bprashanth bprashanth added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. labels May 20, 2015
@bprashanth
Copy link
Contributor Author

/ref #8534

@roberthbailey
Copy link
Contributor

Interesting. I did swap out the node names in the unit test as part of #6949 to be 127.0.0.1, party because I thought that it wouldn't have any problems resolving during unit tests.

@roberthbailey roberthbailey self-assigned this May 20, 2015
@bprashanth bprashanth mentioned this issue May 20, 2015
Closed
@timothysc
Copy link
Member

/cc @eparis

@roberthbailey roberthbailey mentioned this issue May 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roberthbailey roberthbailey

Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix kubelet tests for systems without functional dns to look up localhost roberthbailey/kubernetes
3 participants
@timothysc @roberthbailey @bprashanth