Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut and vendor cAdvisor release for 1.16 #81228

Closed
dashpole opened this issue Aug 9, 2019 · 6 comments · Fixed by #81972
Closed

Cut and vendor cAdvisor release for 1.16 #81228

dashpole opened this issue Aug 9, 2019 · 6 comments · Fixed by #81972
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone
v1.16

Comments

@dashpole
Copy link
Contributor

dashpole commented Aug 9, 2019

For each kubernetes release, we cut a new cadvisor release, and vendor it in. This issue tracks this for the 1.16 release.
@dashpole dashpole added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 9, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 9, 2019
@dashpole
Copy link
Contributor Author

dashpole commented Aug 9, 2019

/sig node
/priority important-soon
/kind process

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 9, 2019
@dashpole
Copy link
Contributor Author

dashpole commented Aug 9, 2019

/kind bug
since there are many bug-fixes included in this release
cc @sjenning

@dchen1107 can you add this to the 1.16 release?

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 9, 2019
@dchen1107
Copy link
Member

@dashpole I cannot see v1.16 milestone here. Maybe the permission for me to update the milestone is removed now?

@dchen1107
Copy link
Member

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 9, 2019
@dashpole dashpole mentioned this issue Aug 26, 2019
Merged
@ttousai
Copy link

ttousai commented Aug 27, 2019 •
edited
Loading

Hello @dashpole ! I'm a bug triage shadow for the 1.16 release cycle and considering this issue is tagged for 1.16, I'd like to check its status. Code freeze is starting on August 29th (about 2 days from now.

Do we still target this issue to be fixed for 1.16?

@dashpole
Copy link
Contributor Author

Yes, this is still targeted for 1.16. #81972 is the only required PR, and will close this issue once it merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
v1.16
Development

Successfully merging a pull request may close this issue.

update cAdvisor godeps to v0.34.0 release dashpole/kubernetes
4 participants
@dashpole @ttousai @dchen1107 @k8s-ci-robot