Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup feature gates which should be removed in 1.16 #79308

Closed
6 tasks done
draveness opened this issue Jun 23, 2019 · 5 comments · Fixed by #79307 or #79309
Closed
6 tasks done

Cleanup feature gates which should be removed in 1.16 #79308

draveness opened this issue Jun 23, 2019 · 5 comments · Fixed by #79307 or #79309
Assignees
@draveness
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@draveness
Copy link
Contributor

draveness commented Jun 23, 2019 •
edited
Loading

The features flag below should be removed from the codebase.
@draveness draveness added the kind/bug Categorizes issue or PR as related to a bug. label Jun 23, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 23, 2019
@draveness draveness mentioned this issue Jun 23, 2019
Merged
@draveness
Copy link
Contributor Author

/assign
/priority important-soon
/sig release // not sure, feel free to remove this

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 23, 2019
This was referenced Jun 23, 2019
Merged
Merged
@BenTheElder
Copy link
Member

/retitle Cleanup feature gates which should be removed in 1.16
I saw this issue and thought we were removing the features themselves 😅

@k8s-ci-robot k8s-ci-robot changed the title Cleanup kube features which should be removed in 1.16 Cleanup feature gates which should be removed in 1.16 Jun 23, 2019
@draveness
Copy link
Contributor Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@draveness: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jun 24, 2019
@liggitt liggitt added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 24, 2019
@draveness
Copy link
Contributor Author

/retitle Cleanup feature gates which should be removed in 1.16
I saw this issue and thought we were removing the features themselves 😅

Sorry for that 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draveness draveness

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
4 participants
@BenTheElder @liggitt @draveness @k8s-ci-robot