-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubelet default argument inconsistency between flags and config file #68939
Comments
/sig node |
see #59666 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
The defaults are intentionally different, since the transition from flags to config provided the opportunity to fix some insecure flag defaults. Agree that the help should do a better job of telling folks what the defaults are in each case. |
/remove-lifecycle stale |
I am running into this trying to run kubelet in standalone mode on
But the ostensibly equivalent config file: kind: KubeletConfiguration
apiVersion: kubelet.config.k8s.io/v1beta1
address: 127.0.0.1
cgroupDriver: systemd
staticPodPath: /etc/kubelet.d
authorization:
mode: AlwaysAllow gives the following error:
|
Standalone mode isn't the mode we configure defaults to target, so it's expected that users may have to reconfigure the auth settings, or others, to fit that mode of operation if they opt into it. Users didn't have to do this with flags because the defaults for server mode were insecure. We fixed this in the config file, which represents a new version of the config API. That defaults may differ is intentional, and documented here: https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/#start-a-kubelet-process-configured-via-the-config-file If someone wants to fix the help, I'm happy to review the PR... |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
For the next person who hits this, I figured out the expected values. So when you --config, authentication is defaulted to webhook where as via the cli it's set to anonymous by default.
NOTE: it would be awesome to generated default configs in the actual yaml/json structure somewhere rather than having to work backwards in go (which I am not that familiar with). |
even with this ☝️ it doesn't work for me.
It recognizes it very well though;
|
DAMN. It was a typo. ( webook )
|
@furkanmustafa good spot, I've updated the example in my comment. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
I tried to start a kubelet in standalone mode but got an error
failed to run Kubelet: no client provided, cannot use webhook authentication
What you expected to happen:
I expected the kubelet to start up without needing a client because
kubelet --help
says:However looking at the code I see:
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/config/v1beta1/defaults.go#L75
(defaults to webhook). Since I'm using a config file and the help tells me to do as much, it should either tell me the flag has a default of alwaysallow and the config has a default of webhook, OR the defaults should be consistent.
How to reproduce it (as minimally and precisely as possible):
Run kubelet, maybe with a config file
Anything else we need to know?:
kubelet systemd file:
kubelet config file
Environment:
a recent version of kubelet
The text was updated successfully, but these errors were encountered: