Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler is not using watch to monitor nodes #6563

Closed
fgrzadkowski opened this issue Apr 8, 2015 · 4 comments
Closed

Scheduler is not using watch to monitor nodes #6563

fgrzadkowski opened this issue Apr 8, 2015 · 4 comments
Assignees
@wojtek-t
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.

Comments

@fgrzadkowski
Copy link
Contributor

For some reason scheduler has a logic to watch nodes, but it is disabled:

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/plugin/pkg/scheduler/factory/factory.go#L169

This is not very heavy, because there will be up to 100 nodes, but we should get rid of this.

@lavalamp @davidopp @wojtek-t
@fgrzadkowski fgrzadkowski added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. team/master labels Apr 8, 2015
@fgrzadkowski fgrzadkowski mentioned this issue Apr 8, 2015
Closed
3 tasks
@wojtek-t wojtek-t self-assigned this Apr 8, 2015
@piosz piosz added this to the v1.0 milestone Apr 8, 2015
@fgrzadkowski
Copy link
Contributor Author

@piosz This is not a blocker for v1.0

@fgrzadkowski fgrzadkowski removed this from the v1.0 milestone Apr 8, 2015
@wojtek-t
Copy link
Member

wojtek-t commented Apr 8, 2015

@lavalamp
Is it possible to replace a poller with simple "watch with field selector" here:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/plugin/pkg/scheduler/factory/factory.go#L169
?

Basically pollMinions filters out all nodes that doesn't have condition NodeReady (plus are unschedulable, but this is easy to change to field selector). The problem is that "Node.Status.Conditions" is an array and IIUC there is currently no support for selectors on arrays.
Do we want to add it?

The alternative would be to wrap the watch interface + filtering function into another watch interface.

@lavalamp
Copy link
Member

lavalamp commented Apr 8, 2015

@wojtek-t I almost did this yesterday as part of #6546, but ended up not doing it. I think watch everything and filter in the client on request is probably easiest.

@wojtek-t wojtek-t mentioned this issue Apr 9, 2015
Merged
@wojtek-t
Copy link
Member

Fixed by #6717 and #6857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wojtek-t wojtek-t

Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lavalamp @wojtek-t @piosz @fgrzadkowski