Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support for the deprecated ESIPP beta annotations for v1.8 #64124

Closed
MrHohn opened this issue May 21, 2018 · 5 comments
Closed

Re-add support for the deprecated ESIPP beta annotations for v1.8 #64124

MrHohn opened this issue May 21, 2018 · 5 comments
Assignees
@MrHohn
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@MrHohn
Copy link
Member

MrHohn commented May 21, 2018

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
/sig network

What happened:
In #50224, we removed the support for ESIPP beta annotations in k8s v1.8:

  • service.beta.kubernetes.io/external-traffic
  • service.beta.kubernetes.io/healthcheck-nodeport

But turned out that is problematic, because the GA API field was only available since k8s v1.7 (added by #41162). With a combination of master on 1.8 and nodes on 1.6, neither the API fields nor the beta annotations is usable. The worse thing is, setting only the beta annotation to OnlyLocal with such combination might cause partial of the LB traffic get blackholed, because the master will configure LB to send traffic to all nodes, while the nodes that don't have backends on it will drop the packet.

We should re-add support for these annotation for 1.8.

How to reproduce it (as minimally and precisely as possible):
Create a cluster with master on 1.8 and nodes on a lower version and observer ESIPP beta annotations not working.

Anything else we need to know?:
cc @bowei
/assign
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. labels May 21, 2018
@MrHohn
Copy link
Member Author

MrHohn commented May 23, 2018

One thing to note, we used to have validation logic to disallow mixing the usage of beta annotation and api field. But to workaround the 1.8 master with 1.6 nodes case, users have to specify both beta annotation and api field (for ESIPP) on service.

Directly reverting #50224 might break them again. And rewriting those logic could be risky (unexpected side effect).

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea aojea mentioned this issue Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrHohn MrHohn

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MrHohn @k8s-ci-robot @fejta-bot