Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env var expansion guidelines #64045

Closed
msau42 opened this issue May 18, 2018 · 10 comments
Closed

Env var expansion guidelines #64045

msau42 opened this issue May 18, 2018 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@msau42
Copy link
Member

msau42 commented May 18, 2018

Is this a BUG REPORT or FEATURE REQUEST?:
@kubernetes/sig-node-feature-requests

What happened:
Before moving kubernetes/enhancements#559 to beta, we should have some further discussions about env expansion in general. Specifically:

  • Are there better ways to implement this? Right now, each case of env expansion is handled independently at different points, and revalidation is considered specifically for each case. Is a general/common solution feasible?
  • If not, can we identify some standard/criteria for what fields should be allowed for expansion, and how they should handle revalidation.
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/feature Categorizes issue or PR as related to a new feature. labels May 18, 2018
@msau42
Copy link
Member Author

msau42 commented May 18, 2018

cc @kevtaylor

@msau42 msau42 mentioned this issue May 18, 2018
Merged
@kevtaylor kevtaylor mentioned this issue Jun 1, 2018
Closed
@kevtaylor kevtaylor mentioned this issue Jul 6, 2018
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2018
@msau42
Copy link
Member Author

msau42 commented Aug 16, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 16, 2018
@thockin
Copy link
Member

thockin commented Aug 23, 2018

I don't think there is a general solution to revalidation, and there isn't a generic "do expansions" hook in the lifecycle. Can you be more concrete in what you're proposing? I'd love to be more rigourous here, if we can...

@msau42
Copy link
Member Author

msau42 commented Aug 23, 2018

I wasn't proposing anything, just wanted to explore if there was a more general way we could do field expansion and not special-case each field. After the last few discussions, I've come to the conclusion that a general in-place expansion mechanism is not feasible due to:

  1. Breaking API compatibility
  2. Timing challenges of revalidation of the fields after expansion

@thockin
Copy link
Member

thockin commented Aug 23, 2018 via email

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 21, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 21, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thockin @k8s-ci-robot @msau42 @fejta-bot