Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md5sum not found on OS X #6389

Closed
zmerlynn opened this issue Apr 2, 2015 · 3 comments
Closed

md5sum not found on OS X #6389

zmerlynn opened this issue Apr 2, 2015 · 3 comments
Assignees
@zmerlynn
Labels
area/build-release

Comments

@zmerlynn
Copy link
Member

zmerlynn commented Apr 2, 2015

Filing for @roberthbailey

This code is wrong https://github.com/GoogleCloudPlatform/kubernetes/blob/master/build/common.sh#L595:

      local md5_sum=$(md5sum ${binary_file_path} | awk '{print $1}')

The local needs to be on a separate line from the command execution, and we need to be resilient to md5sum not existing on OS X, like: https://github.com/GoogleCloudPlatform/kubernetes/blob/master/build/common.sh#L263
@roberthbailey
Copy link
Contributor

For once I was actually watching the output of a build and noticed that I was seeing an error about md5sum not being found. I'm building on a mac using boot2docker.

The short_hash function (https://github.com/GoogleCloudPlatform/kubernetes/blob/master/build/common.sh#L256) works fine on my mac as md5 does exist.

@zmerlynn zmerlynn assigned zmerlynn and unassigned ArtfulCoder Apr 3, 2015
@zmerlynn
Copy link
Member Author

zmerlynn commented Apr 3, 2015

Actually, I'm just going to fix this as a follow-on to #6369.

@zmerlynn zmerlynn mentioned this issue Apr 3, 2015
Merged
@ArtfulCoder
Copy link
Contributor

@zmerlynn Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmerlynn zmerlynn

Labels
area/build-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ArtfulCoder @zmerlynn @roberthbailey