Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test failed] [1.10 upgrade] Proxy version v1 #60769

Closed
krzyzacy opened this issue Mar 5, 2018 · 10 comments
Closed

[test failed] [1.10 upgrade] Proxy version v1 #60769

krzyzacy opened this issue Mar 5, 2018 · 10 comments
Assignees
@liggitt @mikedanese @caseydavenport @dcbw
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/network Categorizes an issue or PR as relevant to SIG Network.
Milestone
v1.10

Comments

@krzyzacy
Copy link
Member

krzyzacy commented Mar 5, 2018

the tests are failing in http://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-1.9-master-upgrade-master

/sig network
/priority failing-test
/priority critical-urgent
/kind bug
/status approved-for-milestone

cc @jdumars @jberkus
/assign @thockin @dcbw @caseydavenport
@k8s-ci-robot k8s-ci-robot added status/approved-for-milestone sig/network Categorizes an issue or PR as relevant to SIG Network. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. labels Mar 5, 2018
@krzyzacy krzyzacy added this to the v1.10 milestone Mar 5, 2018
@liggitt
Copy link
Member

liggitt commented Mar 5, 2018

getting a 404 on the request. is there any chance these are 1.9 e2e tests running on a 1.10 master?

@liggitt
Copy link
Member

liggitt commented Mar 5, 2018 •
edited
Loading

appears to be... 404; 17.489542ms): path /api/v1/proxy/namespaces/e2e-tests-proxy-6gpj9

the deprecated /api/v1/proxy/... paths were removed in #59884

do we need to go back and conditionally disable these tests in the 1.9 branch if running against a 1.10 or newer server?

/assign @mikedanese

@jberkus jberkus mentioned this issue Mar 5, 2018
Closed
@thockin thockin removed their assignment Mar 5, 2018
@jdumars
Copy link
Member

jdumars commented Mar 7, 2018

@mikedanese any update on this?

@liggitt liggitt mentioned this issue Mar 8, 2018
Merged
@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

/assign

@liggitt
Copy link
Member

liggitt commented Mar 13, 2018

/status in-progress

@liggitt liggitt mentioned this issue Mar 13, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Mar 15, 2018
Merge pull request #61135 from liggitt/version-gate-proxy-1.9
6cfd350 
Automatic merge from submit-queue.

Prevent 1.9 e2es testing deprecated/removed features in 1.10

1.9 e2e tests get run against 1.10.0+ masters during upgrade tests. This version-gates testing deprecated features removed in 1.10

http://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-1.9-master-upgrade-master

Fixes #60769
Fixes #60767
@liggitt
Copy link
Member

liggitt commented Mar 15, 2018

fixed by #61135

@liggitt liggitt closed this as completed Mar 15, 2018
@krzyzacy krzyzacy reopened this Mar 16, 2018
@krzyzacy
Copy link
Member Author

looks like http://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-1.9-master-upgrade-cluster-parallel is still failing on this, which should have the 1.9 fix in

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Issue: Up-to-date for process

@caseydavenport @dcbw @krzyzacy @liggitt @mikedanese

Note: This issue is marked as priority/critical-urgent, and must be updated every 1 day during code freeze.

Example update:

ACK.  In progress
ETA: DD/MM/YYYY
Risks: Complicated fix required
Issue Labels
  • sig/network: Issue will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move issue out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@liggitt liggitt mentioned this issue Mar 16, 2018
Merged
@liggitt
Copy link
Member

liggitt commented Mar 16, 2018

opened #61289 to correctly skip those tests

k8s-github-robot pushed a commit that referenced this issue Mar 17, 2018
Merge pull request #61289 from liggitt/proxy-prefix-test
a486807 
Automatic merge from submit-queue.

check server version at correct point in e2e flow

in ginkgo, skip check needed to be done inside the `It("...", func(){ ... })` blocks

fixes #60769 for real this time
@liggitt
Copy link
Member

liggitt commented Mar 17, 2018

Green run of http://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-1.9-master-upgrade-cluster-parallel

Properly skipped these tests

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liggitt liggitt

@mikedanese mikedanese

@caseydavenport caseydavenport

@dcbw dcbw

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
v1.10
Development

No branches or pull requests
9 participants
@liggitt @jdumars @krzyzacy @mikedanese @caseydavenport @thockin @dcbw @k8s-github-robot @k8s-ci-robot