-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pkg/kubelet/config to v1beta3 #5630
Comments
Thanks for the http_test.go fix @yujuhong ! cc @vmarmol As soon as both are done, I think we can start thinking of getting rid of support for ContainerManifest from there. I'm also happy to work on it. |
@wojtek-t since the Container VM relies on, and we publish examples using, the ContainerManifest I don't think we can remove our ability to take it in just yet. We should at least announce the deprecation in Container VMs and change all our examples. A tool to change manifests would be nice too, I think we can do that today easily as well. |
Thanks Victor. Just few questions:
|
@vmarmol @wojtek-t ContainerVM is not a product. It is used by internal teams. However, we're not committed to continuing to improve and evolve ContainerVM for them. We should announce the deprecation of ContainerVM ASAP. We're definitely going to nuke it along with the rest of v1beta1 if not sooner. |
@bgrant0607 That is what I thought for a while until EricH pointed me this public page: https://cloud.google.com/compute/docs/containers/container_vms Sounds like we talked about it, but no real action is performed. |
As soon as #3372 is done (all necessary PRs are already under review), Kubelet will support reading both Pods and ContainerManifest. I looked through the Kubernetes codebase and it seems that there are no references to ContainerManifest anywhere. So I think that the only remaining work here would be related to ContainerVM. However, from the internal discussions it seems that there is still no consensus what we're going to do with ContainerVM. So I'm not sure if we can do anything about it right now. |
pkg/kubelet/config currently supports v1beta3 (in addition to ContainerManifest). |
This isn't strictly blocking v1beta3 enablement #5475, nor did it block elimination of BoundPods. However, at some point prior to 1.0 we're going to nuke ContainerManifest and v1beta1. Kubelet should start consuming v1beta3 sooner rather than later.
Additionally, pkg/kubelet/config/http_test.go serializes api.ContainerManifest in several places. The internal representation should never be serialized. This is blocking removal of the json tags from pkg/api/types.go #3933.
The text was updated successfully, but these errors were encountered: